Skip to content

Remove sizes=auto as the functionality is now available in WordPress core #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mukeshpanchal27 merged 2 commits into from
Aug 25, 2025
Merged

Remove sizes=auto as the functionality is now available in WordPress core #2146

mukeshpanchal27 merged 2 commits into from
Aug 25, 2025

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Aug 25, 2025

Summary

Follow-up #2145

See #2145 (comment): Since Enhanced Responsive Images (formerly auto-sizes) now requires WordPress 6.8, the sizes=auto attribute is redundant and should be removed from the plugin.

@mukeshpanchal27 mukeshpanchal27 added this to the auto-sizes 1.7.0 milestone Aug 25, 2025
@mukeshpanchal27 mukeshpanchal27 self-assigned this Aug 25, 2025
@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) labels Aug 25, 2025
@codecov
Copy link

codecov bot commented Aug 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.64%. Comparing base (00536d7) to head (21a8ec3).
⚠️ Report is 4 commits behind head on trunk.

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk    #2146   +/-   ##
=======================================
  Coverage   68.64%   68.64%           
=======================================
  Files          90       90           
  Lines        7969     7969           
=======================================
  Hits         5470     5470           
  Misses       2499     2499
Flag Coverage Δ
multisite 68.64% <ø> (ø)
single 35.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review August 25, 2025 05:24
@github-actions
Copy link

github-actions bot commented Aug 25, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Aug 25, 2025
Merged
1 task
@mukeshpanchal27 mukeshpanchal27 merged commit 6274111 into trunk Aug 25, 2025
18 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the remove/auto-sizes-functionality branch August 25, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill joemcgill is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

auto-sizes 1.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mukeshpanchal27 @westonruter