Remove responsive image sizes computation #2109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
requested review from
felixarntz,
mukeshpanchal27 and
thelovekesh
as code owners
westonruter
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
force-pushed
the
fix/image-prioritizer-sizes
branch
from
290a500 to
3d220dd
Compare
Member
Author
|
Build for testing: image-prioritizer.zip |
ShyamGadde
approved these changes
Aug 5, 2025
Contributor
ShyamGadde
left a comment
ShyamGadde
left a comment
There was a problem hiding this comment.
Tested the changes locally and didn’t run into any issues in the areas I could check, all seems good 👍
Member
Author
|
Another build for testing: image-prioritizer.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2098
There is an edge case that makes the current
sizescomputation unreliable in Image Prioritizer. Therefore, the logic needs to be removed, at least until a better alternative can be determined. Nevertheless, we now havesizescomputation in Enhanced Responsive Images which can make this redundant anyway.This PR also introduces
npm run update-test-case-snapshotswhich can be used to move theactual.htmlfiles on top of theexpected.htmlfiles in thetest-casesdirectories where snapshot testing is used. This command was run to update the snapshots in 8cf0377 with the removal of thecompute_sizes()method.Lastly, this PR adds a link to an "Optimization Detective Default Disabled" plugin which was used to help troubleshoot this issue.