Skip to content

Use wp_is_rest_endpoint() to detect if we are handling a REST API request#2094

Merged
mukeshpanchal27 merged 2 commits intotrunkfrom
use/wp-function-rest-endpoint
Jul 22, 2025
Merged

Use wp_is_rest_endpoint() to detect if we are handling a REST API request#2094
mukeshpanchal27 merged 2 commits intotrunkfrom
use/wp-function-rest-endpoint

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jul 22, 2025

Summary

Follow-up to #1206 implementation:

We bumped the WordPress minimum version to 6.6 in #1683, so in perflab_rest_post_dispatch_add_server_timing(), we can now safely use the core WordPress function wp_is_rest_endpoint () mentioned in the TODO comment.

In the PR i update the code to use that function and remove the TODO.

Relevant technical choices

@mukeshpanchal27 mukeshpanchal27 self-assigned this Jul 22, 2025
@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Jul 22, 2025
@codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.18%. Comparing base (e6f4f18) to head (e2c565c).
Report is 3 commits behind head on trunk.

Files with missing lines Patch % Lines
...s/performance-lab/includes/server-timing/hooks.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk    #2094   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files          93       93           
  Lines        7750     7750           
=======================================
  Hits         5207     5207           
  Misses       2543     2543
Flag Coverage Δ
multisite 67.18% <0.00%> (ø)
single 36.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 22, 2025 04:29
@github-actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: b1ink0 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 merged commit f559f15 into trunk Jul 22, 2025
24 of 25 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the use/wp-function-rest-endpoint branch July 22, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@b1ink0 b1ink0 b1ink0 approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz

@joemcgill joemcgill Awaiting requested review from joemcgill

@ShyamGadde ShyamGadde Awaiting requested review from ShyamGadde

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

performance-lab 4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mukeshpanchal27 @westonruter @b1ink0