Skip to content

Make settings section title properly translatable #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 4 commits into from
Jun 12, 2025
Merged

Make settings section title properly translatable #2042

felixarntz merged 4 commits into from
Jun 12, 2025

Conversation

@alexclassroom
Copy link
Contributor

@alexclassroom alexclassroom commented Jun 9, 2025

Summary

This plugin adds a feature section to the Settings => Reading page, with the section name 'View Transitions', matching the plugin name.

For most languages, translators don't translate the plugin name, even if it has meaning; however, they should translate the feature section name with meaning.

Relevant technical choices

Making the feature section name translatable is the best choice.

@alexclassroom alexclassroom requested a review from felixarntz as a code owner June 9, 2025 06:56
@github-actions
Copy link

github-actions bot commented Jun 9, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: alexclassroom <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.02%. Comparing base (77d137f) to head (8f02534).
Report is 5 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/view-transitions/includes/settings.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk    #2042   +/-   ##
=======================================
  Coverage   68.02%   68.02%           
=======================================
  Files          92       92           
  Lines        7627     7627           
=======================================
  Hits         5188     5188           
  Misses       2439     2439
Flag Coverage Δ
multisite 68.02% <0.00%> (ø)
single 36.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

felixarntz
felixarntz approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexclassroom Thank you, great catch!

Just one minor feedback, but otherwise this looks good to me.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] View Transitions Issues for the View Transitions plugin labels Jun 9, 2025
@felixarntz felixarntz added this to the view-transitions n.e.x.t milestone Jun 9, 2025
@felixarntz felixarntz changed the title Improve I18N Issue Based on 1.0.1 Make settings section title properly translatable Jun 9, 2025
@felixarntz felixarntz merged commit d13fba1 into WordPress:trunk Jun 12, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixarntz felixarntz felixarntz approved these changes

Assignees

No one assigned

Labels

[Plugin] View Transitions Issues for the View Transitions plugin [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

view-transitions 1.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alexclassroom @felixarntz