Fix view transitions setting values not being saved#2036
Fix view transitions setting values not being saved#2036felixarntz merged 2 commits intoWordPress:trunkfrom
Conversation
… options input handling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #2036 +/- ##
=======================================
Coverage 68.06% 68.06%
=======================================
Files 92 92
Lines 7626 7626
=======================================
Hits 5191 5191
Misses 2435 2435
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westonruter
added
[Plugin] View Transitions
There was a problem hiding this comment.
Yikes! This must have broken at some point late during #2025, because I had tested it before and confirmed it working.
Thanks for catching that @Soean!
This reminds me... it's an early release, but we should really add unit test coverage. :)
Since this is a rather critical bug/limitation, I'll publish this fix in a 1.0.1.
felixarntz
changed the title
3 participants
Summary
The
plvt_sanitize_setting()function of theview transitionsplugin sanitizes the default values, not the input values. Currently, the new input values of the selectors are not saved. This PR fixes the problem.