Skip to content

Remove deprecated url_metrics_group_collection and class aliases and bump required OD version in Image Prioritizer #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 11 commits into from
Mar 25, 2025
Merged

Remove deprecated url_metrics_group_collection and class aliases and bump required OD version in Image Prioritizer #1943

westonruter merged 11 commits into from
Mar 25, 2025
+7 −27

Conversation

@hbhalodia
Copy link
Contributor

@hbhalodia hbhalodia commented Mar 18, 2025 •
edited
Loading

Summary

  • Remove the class aliases url_metrics_group_collection which was deprecated in version 0.7.0 and bump required OD version in image priortizer to 1.0.0-beta3

Relevant technical choices

  • Removed the constant that were defined in deprecated.php file in optimization detective plugin, and used the class constant in image priortizer plugin instead.
  • Updated the required_od_version to 1.0.0-beta3 in image priortizer plugin.
  • Removed unused class aliases from the optimization detective plugin.

@hbhalodia
Remove the constant from deprecated file and use class constant
f4540bd 
Also updated the required optimization detective plugin version so that image priortizer plugin could not break and removed some of the class aliasis that are not required
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@hbhalodia hbhalodia mentioned this pull request Mar 18, 2025
Open
@westonruter
Copy link
Member

westonruter commented Mar 18, 2025

Any reference to ->url_metrics_group_collection in the codebase should be replaced with ->url_metric_group_collection. This should fix the test failures.

hbhalodia
hbhalodia commented Mar 19, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.24%. Comparing base (272b581) to head (b6838f8).
Report is 9 commits behind head on trunk.

Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk    #1943      +/-   ##
==========================================
- Coverage   72.25%   72.24%   -0.02%     
==========================================
  Files          85       85              
  Lines        6952     6953       +1     
==========================================
  Hits         5023     5023              
- Misses       1929     1930       +1
Flag Coverage Δ
multisite 72.24% <100.00%> (-0.02%) ⬇️
single 40.67% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarthak-19 sarthak-19 added [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature labels Mar 19, 2025
@hbhalodia
Copy link
Contributor Author

hbhalodia commented Mar 20, 2025

Hi @westonruter, This is now ready for review.

Thank You,

westonruter
westonruter requested changes Mar 21, 2025
View reviewed changes
@hbhalodia hbhalodia requested a review from westonruter March 25, 2025 04:52
@hbhalodia hbhalodia changed the title Fix: Remove constant from the deprecated.php in optimization-detective plugin Remove url_metrics_group_collection and related class aliases as deprecated long time back Mar 25, 2025
@hbhalodia hbhalodia changed the title Remove url_metrics_group_collection and related class aliases as deprecated long time back Remove url_metrics_group_collection and class aliases and bump required OD version in image priortizer Mar 25, 2025
westonruter
westonruter approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the persistent with this!

@westonruter westonruter changed the title Remove url_metrics_group_collection and class aliases and bump required OD version in image priortizer Remove deprecated url_metrics_group_collection and class aliases and bump required OD version in Image Prioritizer Mar 25, 2025
@westonruter westonruter added the [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) label Mar 25, 2025
@westonruter westonruter merged commit ee3fe25 into WordPress:trunk Mar 25, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz felixarntz is a code owner

Assignees

No one assigned

Labels

[Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

optimization-detective 1.0.0-beta4

Development

Successfully merging this pull request may close these issues.

3 participants

@hbhalodia @westonruter @sarthak-19