Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov badge #1935

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add Codecov badge #1935

merged 1 commit into from
Mar 18, 2025

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Mar 17, 2025

Relates to #1789

It would be nice to add badges distinct for each plugin, and apparently this is possible if we configure flags: https://community.codecov.com/t/coverage-badge-on-a-per-directory-basis/3158

image

@westonruter westonruter added Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Mar 17, 2025
@ShyamGadde
Copy link
Contributor

ShyamGadde commented Mar 18, 2025

It would be nice to add badges distinct for each plugin, and apparently this is possible if we configure flags: https://community.codecov.com/t/coverage-badge-on-a-per-directory-basis/3158

@westonruter I just realized that my Option 1 suggestion here proposed adding per-plugin flags, which would also help with this coverage badge implementation—along with carrying forward coverage when doing partial testing.

Since PR #1838 hasn't been merged yet, would you recommend switching to Option 1 now? That way, we can solve both issues in a single step.

Copy link

github-actions bot commented Mar 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: ShyamGadde <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter
Copy link
Member Author

@ShyamGadde ah, right!

@swissspidy what do you think?

@westonruter westonruter added the [Type] Enhancement A suggestion for improvement of an existing feature label Mar 18, 2025
@westonruter westonruter merged commit 69b7a14 into trunk Mar 18, 2025
10 of 14 checks passed
@westonruter westonruter deleted the add/codecov-badge branch March 18, 2025 18:40
@westonruter
Copy link
Member Author

In regards to having separate badges for each plugin, I will say that it is very easy to see the breakdown by plugin when going to https://app.codecov.io/gh/WordPress/performance

image

Or at https://app.codecov.io/gh/WordPress/performance/tree/trunk/plugins

image

@ShyamGadde so if the work needed to implement as you referred to in #1935 (comment) is high, then it may not be worth it.

@ShyamGadde
Copy link
Contributor

ShyamGadde commented Mar 18, 2025

@westonruter The work required to implement this isn’t actually that high. I already tested and verified the setup in a separate repo before suggesting it. So switching to Option 1 would be relatively quick and straightforward. Let me know if you'd like me to proceed with this!

@westonruter
Copy link
Member Author

@ShyamGadde Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants