-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Codecov badge #1935
Add Codecov badge #1935
Conversation
@westonruter I just realized that my Option 1 suggestion here proposed adding per-plugin flags, which would also help with this coverage badge implementation—along with carrying forward coverage when doing partial testing. Since PR #1838 hasn't been merged yet, would you recommend switching to Option 1 now? That way, we can solve both issues in a single step. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@ShyamGadde ah, right! @swissspidy what do you think? |
In regards to having separate badges for each plugin, I will say that it is very easy to see the breakdown by plugin when going to https://app.codecov.io/gh/WordPress/performance @ShyamGadde so if the work needed to implement as you referred to in #1935 (comment) is high, then it may not be worth it. |
@westonruter The work required to implement this isn’t actually that high. I already tested and verified the setup in a separate repo before suggesting it. So switching to Option 1 would be relatively quick and straightforward. Let me know if you'd like me to proceed with this! |
@ShyamGadde Sounds good to me. |
Relates to #1789
It would be nice to add badges distinct for each plugin, and apparently this is possible if we configure flags: https://community.codecov.com/t/coverage-badge-on-a-per-directory-basis/3158