Revert gzip compression of URL Metric data #1929

westonruter · 2025-03-16T16:19:05Z

Summary

Fixes #1928
This reverts #1905

Relevant technical choices

An alternative to this is #1924 which keeps the code to gzip-compression the URL Metric in the codebase, but just disables it by default. However, since I found that Safari and Firefox always fail to send a URL Metric at pagehide when compression is involved, and Chrome also usually fails as well, it seems better to remove this code since it is not safe to use currently. Hopefully this revert can be reverted so we can benefit from gzip compression again!

github-actions · 2025-03-16T16:19:20Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: b1ink0 <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

codecov · 2025-03-16T16:27:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.20%. Comparing base (47eef00) to head (b92b042).
Report is 3 commits behind head on release/2025-03-17.

Additional details and impacted files

@@                  Coverage Diff                   @@
##           release/2025-03-17    #1929      +/-   ##
======================================================
- Coverage               71.39%   71.20%   -0.19%     
======================================================
  Files                      86       86              
  Lines                    7043     6998      -45     
======================================================
- Hits                     5028     4983      -45     
  Misses                   2015     2015

Flag	Coverage Δ
multisite	`71.20% <100.00%> (-0.19%)`	⬇️
single	`40.69% <0.00%> (+0.26%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

b1ink0

This test case should be removed.

performance/plugins/optimization-detective/tests/storage/test-class-od-rest-url-metrics-store-endpoint.php

Lines 395 to 412 in ddcd3ae

    
           'invalid_decoded_json_body_content_length' => array( 
        
           	'params'          => array_merge( 
        
           		$valid_params, 
        
           		array( 
        
           			// Fill the JSON with more than 1MB of highly compressible data. 
        
           			'elements' => array( 
        
           				array_merge( 
        
           					$valid_element, 
        
           					array( 
        
           						'xpath' => sprintf( '/HTML/BODY/DIV[@id=\'%s\']/*[1][self::DIV]', str_repeat( 'A', MB_IN_BYTES ) ), 
        
           					) 
        
           				), 
        
           			), 
        
           		) 
        
           	), 
        
           	'expected_status' => 413, 
        
           	'expected_code'   => 'rest_content_too_large', 
        
           ),

Co-authored-by: b1ink0 <[email protected]>

felixarntz

Thanks @westonruter for catching that.

It's a bummer this needs to be reverted, but we can hopefully reinstate it soon. This is something we can maybe reconsider post-1.0.0, as I don't anticipate it changing the API in any significant way.

I personally agree with your point from the ticket that we should eventually reintroduce this, despite the negative impact on BFCache for users where URL metrics are collected.

…etric-gzip-compression" This reverts commit aef2e8d, reversing changes made to 47eef00.

Revert gzip compression of URL Metric data

ddcd3ae

westonruter added [Type] Bug An existing feature is broken [Plugin] Optimization Detective Issues for the Optimization Detective plugin skip changelog PRs that should not be mentioned in changelogs labels Mar 16, 2025

westonruter added this to the optimization-detective 1.0.0-beta3 milestone Mar 16, 2025

westonruter requested a review from felixarntz as a code owner March 16, 2025 16:19

westonruter mentioned this pull request Mar 16, 2025

Disable gzip compression of URL Metric by default #1924

Closed

westonruter requested a review from b1ink0 March 16, 2025 16:27

b1ink0 requested changes Mar 16, 2025

View reviewed changes

Remove invalid_decoded_json_body_content_length test case

b92b042

Co-authored-by: b1ink0 <[email protected]>

b1ink0 approved these changes Mar 16, 2025

View reviewed changes

westonruter changed the base branch from trunk to release/2025-03-17 March 16, 2025 19:40

This was referenced Mar 17, 2025

Prepare next set of PL releases for 2025-03-17 #1853

Closed

Prepare 2025-03-17 release #1932

Merged

felixarntz approved these changes Mar 17, 2025

View reviewed changes

westonruter merged commit aef2e8d into release/2025-03-17 Mar 17, 2025
22 checks passed

westonruter deleted the revert/url-metric-gzip-compression branch March 17, 2025 15:46

westonruter mentioned this pull request Mar 17, 2025

Explore compressing URL Metrics to work within the 64 KiB limit #1893

Closed

b1ink0 added a commit to b1ink0/performance that referenced this pull request Mar 27, 2025

Revert "Merge pull request WordPress#1929 from WordPress/revert/url-m…

0128b8d

…etric-gzip-compression" This reverts commit aef2e8d, reversing changes made to 47eef00.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert gzip compression of URL Metric data #1929

Revert gzip compression of URL Metric data #1929

Uh oh!

westonruter commented Mar 16, 2025

Uh oh!

github-actions bot commented Mar 16, 2025 •

edited

Loading

Uh oh!

codecov bot commented Mar 16, 2025 •

edited

Loading

Uh oh!

b1ink0 left a comment •

edited

Loading

Uh oh!

felixarntz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	'invalid_decoded_json_body_content_length' => array(
	'params' => array_merge(
	$valid_params,
	array(
	// Fill the JSON with more than 1MB of highly compressible data.
	'elements' => array(
	array_merge(
	$valid_element,
	array(
	'xpath' => sprintf( '/HTML/BODY/DIV[@id=\'%s\']/*[1][self::DIV]', str_repeat( 'A', MB_IN_BYTES ) ),
	)
	),
	),
	)
	),
	'expected_status' => 413,
	'expected_code' => 'rest_content_too_large',
	),

Revert gzip compression of URL Metric data #1929

Revert gzip compression of URL Metric data #1929

Uh oh!

Conversation

westonruter commented Mar 16, 2025

Summary

Relevant technical choices

Uh oh!

github-actions bot commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

b1ink0 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Mar 16, 2025 •

edited

Loading

codecov bot commented Mar 16, 2025 •

edited

Loading

b1ink0 left a comment •

edited

Loading