Include active plugins in ETag data and increase default freshness TTL from 1 day to 1 week #1854
Conversation
westonruter
added
[Type] Enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1854 +/- ##
==========================================
+ Coverage 66.55% 66.64% +0.09%
==========================================
Files 88 88
Lines 6999 7015 +16
==========================================
+ Hits 4658 4675 +17
+ Misses 2341 2340 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Changing the TTL LGTM, but a few questions about the other changes.
Co-authored-by: Felix Arntz <[email protected]>
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks for the updates, LGTM!
Ever since the incorporation of page state into the URL Metric ETag (#1722), the freshness TTL of 1 day has been excessively frequent. Before the ETag, the freshness TTL needed to be a day since there was no mechanism to know whether a recent URL Metric actually corresponded to the current state of the page. This is now changed as the ETag will change whenever a post on the page is updated, the theme is changed, and (new in this PR) a plugin is activated/deactivated.
This PR also adds 3 getter methods which were missing from
OD_URL_Metric_Group_Collectionto access the its private properties.