The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.98%. Comparing base (68c6deb) to head (e961c37).
Report is 7 commits behind head on trunk.

@@           Coverage Diff           @@
##            trunk    #1848   +/-   ##
=======================================
  Coverage   65.97%   65.98%           
=======================================
  Files          88       88           
  Lines        6895     6896    +1     
=======================================
+ Hits         4549     4550    +1     
  Misses       2346     2346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thank you! Could you please add a test case to make sure that this condition is working as expected?

Hi @westonruter, I had tried to add the test case for the same, Could you please check if below is the correct way to add a test case for this?

'singular_as_post_preview'  => array(
  'set_up'   => static function (): string {
	  $post_id = self::factory()->post->create( array( 'post_title' => 'Hello', 'post_status' => 'draft' ) );
	  return get_permalink( $post_id );
  },
  'expected' => false,
),

We can add the above here after this,

If yes, I would update the PR with the changes, I can update the test case name as per the standards.

I do have run the test locally, by mocking this as publish and draft and it results in correct output as expected after adding the condition.

Thank You,

@hbhalodia that mostly looks good, but probably should use get_preview_post_link().

Hi @westonruter, Thanks for the suggestion.

I have one issue, when I try to commit this, phpstan is giving issue related to return value as it should only be string, but function return either string|null. I tried adding the return value to accept string|null, but it throws error related native union type, I committed it with --no-verify, Can you please suggest how can I pass this failed action.

Thank You,

Hi @westonruter, This is now fixed. Updated the PR with the changes and test cases.

Thank You,