Skip to content

Conversation

@ShyamGadde
Copy link
Contributor

Summary

Fixes #1819

@ShyamGadde ShyamGadde added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels Jan 24, 2025
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.96%. Comparing base (0615c18) to head (bd642b4).
Report is 20 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1824      +/-   ##
==========================================
- Coverage   65.96%   65.96%   -0.01%     
==========================================
  Files          88       88              
  Lines        6876     6872       -4     
==========================================
- Hits         4536     4533       -3     
+ Misses       2340     2339       -1     
Flag Coverage Δ
multisite 65.96% <100.00%> (-0.01%) ⬇️
single 38.66% <33.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShyamGadde ShyamGadde marked this pull request as ready for review January 24, 2025 17:29
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ShyamGadde <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShyamGadde Thanks, LGTM!

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@westonruter westonruter merged commit 93257ee into WordPress:trunk Jan 27, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL Metric ETag should now be required since a transitional period has now elapsed

3 participants