Skip visiting any tags inside of NOSCRIPT elements#1783
Conversation
westonruter
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
changed the title
westonruter
modified the milestones:
image-prioritizer n.e.x.t,
optimization-detective n.e.x.t
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1783 +/- ##
==========================================
+ Coverage 57.42% 57.43% +0.01%
==========================================
Files 84 84
Lines 6506 6508 +2
==========================================
+ Hits 3736 3738 +2
Misses 2770 2770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
westonruter
force-pushed
the
fix/od-noscript-handling
branch
from
285da50 to
14f57a8
Compare
westonruter
changed the title
NOSCRIPT elements
2 participants
Any tag which appears in a
NOSCRIPTshould always be excluded from visiting by any tag visitor. For example:Currently this shows up on pages as:
Image Prioritizer adds the
data-od-unknown-tagattribute to any visited tagIMGwhich is not located in URL Metrics. However, such anIMGcan never be added to URL Metrics since it is not located in the DOM.This PR skips over visiting any tag which is inside of a
NOSCRIPTelement.Such
NOSCRIPTtags are often found with JS-based lazy-loading implementations.