Skip to content

Enqueue scripts using plugins_url() instead of plugin_dir_url() #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mukeshpanchal27 merged 2 commits into from
Dec 20, 2024
Merged

Enqueue scripts using plugins_url() instead of plugin_dir_url() #1761

mukeshpanchal27 merged 2 commits into from
Dec 20, 2024

Conversation

@SohamPatel46
Copy link
Contributor

@SohamPatel46 SohamPatel46 commented Dec 19, 2024

Summary

Fixes #1647

Relevant technical choices

@github-actions
Copy link

github-actions bot commented Dec 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SohamPatel46 <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@SohamPatel46
Copy link
Contributor Author

SohamPatel46 commented Dec 19, 2024

Hello, Can someone with access can add the required labels ? I dont seem to have enough access to do that.

@swissspidy swissspidy added this to the performance-lab n.e.x.t milestone Dec 19, 2024
@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) [Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin. [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Dec 19, 2024
westonruter
westonruter approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukeshpanchal27 mukeshpanchal27 merged commit ebec285 into WordPress:trunk Dec 20, 2024
29 of 31 checks passed
@westonruter westonruter changed the title Enqueued scripts should use plugins_url() instead of plugin_dir_url() Enqueue scripts using plugins_url() instead of plugin_dir_url() Jan 25, 2025
@westonruter westonruter mentioned this pull request Jan 25, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz felixarntz is a code owner

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

Assignees

No one assigned

Labels

[Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin. [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

performance-lab 3.8.0

Development

Successfully merging this pull request may close these issues.

Enqueued scripts should use plugins_url() instead of plugin_dir_url()

4 participants

@SohamPatel46 @westonruter @mukeshpanchal27 @swissspidy