Enqueue scripts using plugins_url() instead of plugin_dir_url()#1761
Merged
mukeshpanchal27 merged 2 commits intoWordPress:trunkfrom Dec 20, 2024
Merged
Conversation
SohamPatel46
requested review from
adamsilverstein,
felixarntz,
mukeshpanchal27 and
westonruter
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Hello, Can someone with access can add the required labels ? I dont seem to have enough access to do that. |
swissspidy
added
[Type] Enhancement
mukeshpanchal27
approved these changes
Dec 20, 2024
westonruter
changed the title
plugins_url() instead of plugin_dir_url()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1647
Relevant technical choices
plugin_dir_url()function toplugins_url()function, because the latter one is more appropriate to use whenever we want a path appended at the end of the URL.