Accurate sizes: Support relative alignment widths #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
added
[Type] Enhancement
Member
Author
|
Thanks for fixing those indents, @mukeshpanchal27! Some times my editor's auto-formatting takes on a life of it's own 😅 I'm going to add some unit tests for this (current tests are still passing) and then I this should be ready for review as well. |
westonruter
reviewed
Dec 13, 2024
Co-authored-by: Weston Ruter <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
approved these changes
Dec 13, 2024
joemcgill
merged commit aa340dc
into
feature/1511-incorporate-layout-constraints-from-ancestors
15 checks passed
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an initial concept for supporting relative alignment widths as described in #1511 (comment).
Relevant technical choices
If the layout setting ends in a px value, compare directly with the image width. If the layout setting uses any other value, use a CSS
min()function insizes.This also improves the logic for left/right alignment values so they are constrained by
widelayouts if the image width is larger than the container.To test
30remsizesvalue looks similar tosizes="(max-width: min(20rem, 1024px)) 100vw, min(20rem, 1024px)"