Add fetchpriority=high to IMG when it is the LCP element on desktop and mobile with other viewport groups empty
#1723
Conversation
…and other groups are empty Signed-off-by: Shyamsundar Gadde <[email protected]>
Signed-off-by: Shyamsundar Gadde <[email protected]>
Signed-off-by: Shyamsundar Gadde <[email protected]>
ShyamGadde
force-pushed
the
update/allow-high-fetchpriority-if-lcp-on-atleast-mobile-and-desktop
branch
from
634fd4f to
55ac18a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
This is looking great! Could you also update \Test_OD_URL_Metric_Group_Collection::test_get_common_lcp_element() to add a data provider to test each of the return conditions? I see right now it is lacking in that it only tests the case where it returns an OD_Element. It isn't testing the cases when it can return null.
plugins/optimization-detective/class-od-url-metric-group-collection.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/class-od-url-metric-group-collection.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/class-od-url-metric-group-collection.php
Outdated
Show resolved
Hide resolved
westonruter
added
[Type] Enhancement
Co-authored-by: Weston Ruter <[email protected]>
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Great work @ShyamGadde, LGTM!
Signed-off-by: Shyamsundar Gadde <[email protected]>
Signed-off-by: Shyamsundar Gadde <[email protected]>
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Test cases look great, although I believe they can be a bit simplified. No need to include OD_Element::class in the data provider since it's always going to be the same if the expected is not null.
plugins/optimization-detective/tests/test-class-od-url-metrics-group-collection.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/tests/test-class-od-url-metrics-group-collection.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/tests/test-class-od-url-metrics-group-collection.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/tests/test-class-od-url-metrics-group-collection.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/tests/test-class-od-url-metrics-group-collection.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Weston Ruter <[email protected]>
3 participants
Summary
Fixes #1710
Relevant technical choices
OD_URL_Metric_Group_Collection::get_common_lcp_element()to also consider an LCP element as common if it is identical in the narrowest and widest viewport groups, with all intermediate groups remaining empty.