Fix logic inversion in od_can_optimize_response()#1659
Merged
westonruter merged 1 commit intorelease/3.6.0from Nov 17, 2024
Merged
Fix logic inversion in od_can_optimize_response()#1659westonruter merged 1 commit intorelease/3.6.0from
westonruter merged 1 commit intorelease/3.6.0from
Conversation
westonruter
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Nov 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing the latest plugins on my blog and I was perplexed to find that Optimization Detective wasn't working on any URL. I found out it was due to a logic inversion I introduced in #1641. I didn't notice the issue when testing locally because I have the following dev-mode plugin code running, including:
This means that the checking for
od_get_cache_purge_post_id()I added tood_can_optimize_response()wasn't having any effect. Note that each of the conditions in that function are meant to be negative conditions for which responses should not be optimized. The entire boolean chain of conditions is then negated. So this is why the logic looks correct at first glance, but not if you look at the other conditions in the boolean chain.The issue also was not detected in unit tests because (1) there are no posts created initially when unit tests run so
null !== od_get_cache_purge_post_id()was always returningfalse, and (2) I hadn't explicitly checked the condition for when this is expected to returnnull.These are rectified in this PR.