Eliminate the detection time window #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
requested review from
felixarntz
and removed request for
felixarntz
felixarntz
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR to address #1496.
The detection time window fails to adequately account for page caching so it's gotta go.
When the detection time window is enforced, new URL metrics are only collected if the user happened to visit when there was a page cache MISS or if the user happened to visit a couple seconds from within the time that someone else visited the page and the cache HIT returns a page that is only a couple seconds old. This is problematic, for example, on a site which primarily gets mobile traffic. If mobile visitors always trigger their responses to be cached, then when a desktop visitor comes around the detection time window will have already passed and that URL will be starved of URL Metrics for desktop.
Additionally, on a site that uses a stale-while-revalidate strategy for page caching, it's possible that the cached page is always older than the detection time window, resulting in URL Metrics never being gathered.
Also, a plugin like W3 Total Cache has a "Cache Preload" feature in which it will proactively crawl the site to prime the page cache. Since these requests are not coming from an actual user, they will circumvent a user causing a cache MISS and thus getting a page served within the detection time window.