Avoid lazy-loading images and embeds unless there are URL Metrics for both mobile and desktop #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Plugin] Embed Optimizer
westonruter
requested review from
felixarntz and
adamsilverstein
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3 tasks
swissspidy
added
the
[Type] Enhancement
swissspidy
reviewed
Oct 18, 2024
...ns/image-prioritizer/tests/test-cases/common-lcp-image-with-fully-incomplete-sample-data.php
Outdated
Show resolved
Hide resolved
swissspidy
approved these changes
Oct 18, 2024
felixarntz
approved these changes
Oct 18, 2024
Co-authored-by: Pascal Birchler <[email protected]>
westonruter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #1596 (comment)
We can only safely lazy-load anything once we have collected URL metrics for both mobile and desktop. If we've only collected URL metrics for mobile and there is a lazy-loadable element which is not visible, it would be an error to lazy-load it if that element does get displayed on a larger viewport (e.g. desktop).