Add group collection helper methods to get the first/last groups#1602
Merged
westonruter merged 2 commits intotrunkfrom Oct 17, 2024
Merged
Add group collection helper methods to get the first/last groups#1602westonruter merged 2 commits intotrunkfrom
westonruter merged 2 commits intotrunkfrom
Conversation
westonruter
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
commented
Oct 17, 2024
Comment on lines
-89
to
-94
| $widest_group = array_reduce( | ||
| iterator_to_array( $context->url_metric_group_collection ), | ||
| static function ( $carry, OD_URL_Metric_Group $group ) { | ||
| return ( null === $carry || $group->get_minimum_viewport_width() > $carry->get_minimum_viewport_width() ) ? $group : $carry; | ||
| } | ||
| ); |
Member
Author
There was a problem hiding this comment.
This iteration is now eliminated for every video[poster] in the document.
3 tasks
felixarntz
approved these changes
Oct 17, 2024
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @westonruter, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1596 we need to exclusively look at the desktop group of URL metrics to determine the widest possible width for a given element, excluding widths from narrower viewport groups (e.g. mobile) since they could result in an image size being chosen which would look bad on desktop. This adds a
OD_URL_Metric_Group_Collection::get_last_group()helper method to facilitate this. It also adds aOD_URL_Metric_Group_Collection::get_first_group()for parity.