Introduce get_cursor_move_count() to use instead of get_seek_count() and get_next_token_count() #1478
Conversation
…and get_next_token_count()
…eady incremented in next_token()
westonruter
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| * | ||
| * @since 0.4.1 | ||
| * @see self::next_token() | ||
| * @deprecated Use {@see self::get_cursor_move_count()} instead. |
There was a problem hiding this comment.
Are we deprecating this so dependent plugins don't break? If we don't explicitly call from outside the plugin, couldn't we just remove this?
There was a problem hiding this comment.
Yes, we could just remove it. I'm happy to do do if you think that's best. It's extremely unlikely anyone is using these deprecated methods.
Co-authored-by: adamsilverstein <[email protected]>
When explaining Optimization Detective's iteration over the tags in the document in #1476 (comment), I realized that the naming of the
OD_HTML_Tag_Processor::get_next_token_count()method is poor. It's supposed to count the number of times thatnext_token()was called, but it looks like it gives you a count of the remaining tokens in the document. Also, in addition to this method there isget_seek_count()which returns the underlying protected$seek_countvariable. We don't really need these two methods and can instead have a singleget_cursor_move_count()that keeps track of the number of times thatnext_token()was called (which is what is called both byseek()andnext_tag()).