Disable Optimization Detective by default on the embed template #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
swissspidy
approved these changes
Aug 14, 2024
westonruter
deleted the
update/disable-optimization-detective-on-embed-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some testing with post embeds and I tried embedding a post embed from my blog onto my local test environment. When I did so, I saw an error in the console:
Normally the embed template doesn't have any external scripts, but since Optimization Detective is running on my site it is adding a script module to the page that does a dynamic import of
detect.js. This then is causing an error because the WordPress post iframe is served withsandbox="allow-scripts"which doesn't includeallow-same-origin, meaning the Same-Origin Policy is being enforced, blocking the loading of the script (as I understand).The solution is simply to disable Optimization Detective for the embed template. In reality there is not really a need for optimizations to run on the basic embed template, as there is at most only one or two images and everything is in the viewport. WordPress core is already adding
fetchpriority=highto the featured image in a post embed template.