Remove Server-Timing metric for the autoloaded options query time #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
approved these changes
Aug 9, 2024
swissspidy
approved these changes
Aug 10, 2024
mukeshpanchal27
approved these changes
Aug 12, 2024
mukeshpanchal27
deleted the
remove/autoloaded-options-query-server-timing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Server-Timing metric to capture the time that the autoloaded options query takes was initially introduced primarily to get a better idea for how severe the problem of autoloading options is across WordPress sites. This research was completed more than a year ago and has since already led to several WP core projects and enhancements, see e.g. https://make.wordpress.org/core/2024/06/18/options-api-disabling-autoload-for-large-options/.
At this point, there's no longer a good reason to keep this very specific Server-Timing metric in the Performance Lab plugin, so we can remove it - particularly since it's now slightly incorrect given that WordPress 6.6 introduced additional autoload values than
yesthat would need to be considered. It's not worth updating this though, it just made me remember this existed and should probably be removed now.