Avoid sending Server-Timing header when buffer is being cleaned#1443
Merged
felixarntz merged 3 commits intoupdate/ob-handlingfrom Aug 7, 2024
Merged
Avoid sending Server-Timing header when buffer is being cleaned#1443felixarntz merged 3 commits intoupdate/ob-handlingfrom
felixarntz merged 3 commits intoupdate/ob-handlingfrom
Conversation
westonruter
added
[Type] Bug
westonruter
requested review from
felixarntz and
mukeshpanchal27
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sub-PR of #1317. Merge it first.
As @felixarntz pointed out in #1317 (comment), when a template calls
ob_clean()it can currently result in theServer-Timingheader being sent prematurely. When the buffer is being cleaned, the output buffer callback should not send the header yet because no output is being printed, so it can continue waiting until the output is flushed.This also fixes a bug with passing the argument names when they are missing from the
$argspassed to\Perflab_Server_Timing::register_metric(). The PR also improves escaping the resultant strings.