Facilitate embedding of Embed Optimizer #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
the
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
commented
Jul 9, 2024
Comment on lines
+23
to
+69
| ( | ||
| /** | ||
| * Register this copy of the plugin among other potential copies embedded in plugins or themes. | ||
| * | ||
| * @param string $global_var_name Global variable name for storing the plugin pending loading. | ||
| * @param string $version Version. | ||
| * @param Closure $load Callback that loads the plugin. | ||
| */ | ||
| static function ( string $global_var_name, string $version, Closure $load ): void { | ||
| if ( ! isset( $GLOBALS[ $global_var_name ] ) ) { | ||
| $bootstrap = static function () use ( $global_var_name ): void { | ||
| if ( | ||
| isset( $GLOBALS[ $global_var_name ]['load'], $GLOBALS[ $global_var_name ]['version'] ) | ||
| && | ||
| $GLOBALS[ $global_var_name ]['load'] instanceof Closure | ||
| && | ||
| is_string( $GLOBALS[ $global_var_name ]['version'] ) | ||
| ) { | ||
| call_user_func( $GLOBALS[ $global_var_name ]['load'], $GLOBALS[ $global_var_name ]['version'] ); | ||
| unset( $GLOBALS[ $global_var_name ] ); | ||
| } | ||
| }; | ||
|
|
||
| // Load in the Embed Optimizer plugin hooks. | ||
| require_once __DIR__ . '/hooks.php'; | ||
| // Wait until after the plugins have loaded and the theme has loaded. The after_setup_theme action is used | ||
| // because it is the first action that fires once the theme is loaded. | ||
| add_action( 'after_setup_theme', $bootstrap, PHP_INT_MIN ); | ||
| } | ||
|
|
||
| // Register this copy of the plugin. | ||
| if ( | ||
| // Register this copy if none has been registered yet. | ||
| ! isset( $GLOBALS[ $global_var_name ]['version'] ) | ||
| || | ||
| // Or register this copy if the version greater than what is currently registered. | ||
| version_compare( $version, $GLOBALS[ $global_var_name ]['version'], '>' ) | ||
| || | ||
| // Otherwise, register this copy if it is actually the one installed in the directory for plugins. | ||
| rtrim( WP_PLUGIN_DIR, '/' ) === dirname( __DIR__ ) | ||
| ) { | ||
| $GLOBALS[ $global_var_name ]['version'] = $version; | ||
| $GLOBALS[ $global_var_name ]['load'] = $load; | ||
| } | ||
| } | ||
| )( | ||
| 'embed_optimizer_pending_plugin', | ||
| '0.1.2', | ||
| static function ( string $version ): void { |
Member
Author
There was a problem hiding this comment.
This block of code is a direct copy of what is in Optimization Detective's load.php.
westonruter
force-pushed
the
add/embeddable-embed-optimizer
branch
from
962a43b to
6911c56
Compare
westonruter
force-pushed
the
add/embeddable-embed-optimizer
branch
from
6911c56 to
36604fe
Compare
westonruter
added
the
[Plugin] Embed Optimizer
swissspidy
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with Optimization Detective and Image Prioritizer, this updates the bootstrap logic for Embed Optimizer so that it can be embedded in a theme or plugin.