Merge initial accurate sizes work into trunk #1329
Conversation
…curate-sizes-image-cover-block
…-cover-block Initial implementation of improved image `sizes` algorithm
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Thanks for getting this open. Leaving a review to mark this as blocked until all of the planned work on this feature for v1 is completed.
Update `Auto-sizes for Lazy-loaded Images` plugin name to `Enhanced Responsive Images` Co-authored-by: mukeshpanchal27 <[email protected]> Co-authored-by: westonruter <[email protected]> Co-authored-by: joemcgill <[email protected]> Co-authored-by: adamsilverstein <[email protected]> Co-authored-by: thelovekesh <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
Update the plugin description for Enhanced Responsive Images
|
@joemcgill @westonruter @swissspidy The PR is ready for review. The version bump and changelog is part of #1332. Can we merge this today, please? |
westonruter
added
skip changelog
|
@joemcgill Is this PR still blocked from merging? @mukeshpanchal27 I've updated the issues and PRs related to this PR to ensure they are all milestoned for |
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
I think this is good to merge into trunk and iterate from there.
The PR merge the initial set of work for accurate sizes to the trunk for release.
Initial feature release issues:
sizesalgorithm #1187sizesvalues #1251sizesfor left/right/center alignment #1289