Include non-intersecting elements in URL metrics to fix lazy-load optimization #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
changed the title
thelovekesh
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Image Prioritizer includes optimization of image lazy-loading, a feature that Optimization Detective (OD) didn't yet implement. The OD plugin only implemented the addition of the
fetchpriority=highattribute to the LCP image. Because of this, its intersection observer was only interested in elements which were intersecting. It ignored anything with anintersectionRatioof0.0. This issue showed up by below-the-fold images having andata-od-unknown-tagattribute, which is also a new feature as of the Image Prioritizer, indicating which tracked elements are absent from the elements in the URL Metrics. By removing theentry.isIntersectingcondition, we can ensure that all tracked elements are included in the URL metrics, not just the ones in the initial viewport.