I18N: Add context to Modern Image Formats section title#1287
Merged
westonruter merged 2 commits intoWordPress:trunkfrom Jul 9, 2024
Merged
I18N: Add context to Modern Image Formats section title#1287westonruter merged 2 commits intoWordPress:trunkfrom
westonruter merged 2 commits intoWordPress:trunkfrom
Conversation
alexclassroom
requested review from
adamsilverstein,
felixarntz and
westonruter
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
reviewed
Jun 7, 2024
westonruter
added
the
[Type] Enhancement
Co-authored-by: Weston Ruter <[email protected]>
swissspidy
approved these changes
Jul 9, 2024
swissspidy
changed the title
mukeshpanchal27
approved these changes
Jul 9, 2024
westonruter
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin name and the Media setting page section name are the same, "Modern Image Formats," so they are the same string, but they should be disambiguated by context.
Relevant technical choices
We don't translate plugin names, but even if the "Modern Image Formats" string in the Media setting page is the same as the plugin name, I think it should be a localizable setting page section name.