Improve message for WebP site health test#1249
Conversation
|
@thelovekesh Some checks are failing due to missing labels, can you add labels to this PR? |
mukeshpanchal27
added
[Plugin] Modern Image Formats
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected], @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks for the PR. The link should be clickable.
westonruter
removed
the
no milestone
westonruter
added
[Plugin] Performance Lab
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Prior to merging these changes, I think we need to consider whether the updated text addresses the issue. See #715 (comment).
plugins/performance-lab/includes/site-health/webp-support/helper.php
Outdated
Show resolved
Hide resolved
|
@the-hercules new suggested text from @adamsilverstein in #715 (comment) |
|
@westonruter does this message looks good ? WebP support can only be enabled by your hosting provider. Please contact them to inquire about switching to a plan that supports WebP, or consider switching to a host that offers this feature. For more information about WebP image support for WordPress sites, please Learn more here. |
I would phrase this rather as:
I'll defer to @adamsilverstein for the ultimate wording. |
|
Looks good, including suggestion from @westonruter |
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
LGTM, with a possible improved word choice.
plugins/performance-lab/includes/site-health/webp-support/helper.php
Outdated
Show resolved
Hide resolved
westonruter
changed the title
|
@mukeshpanchal27 @joemcgill Awaiting Review, I have made the suggested Changes. |
|
Hey @joemcgill , Could you please review this PR. |
5 participants
Fixes #715
Summary
Updated error message in the WordPress performance plugin regarding WebP image support. The message now informs users that WebP images require support from the web server's image processing libraries (Imagick or LibGD) and provides guidance on checking supported file formats.