Update PHPStan to 1.11.1 #1213
Update PHPStan to 1.11.1 #1213
Conversation
westonruter
added
the
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…be used in tests ignore
|
@thelovekesh Sorry, there is one more PR for PHPStan. |
| # TODO: Use error identifiers instead of messages once PHPStan 1.11 is out: <https://github.com/WordPress/performance/issues/1209>. | ||
| - | ||
| message: '/Parameter #\d.+given./' | ||
| identifier: argument.type |
There was a problem hiding this comment.
Note: I tried originally to use identifier: argument.type with the ignored error above in dominant-color-images. However, it seems you can only use an identifier once in the ignoreErrors, or else the ignore is ignored (such ignorance!) But it is better anyway to use the message above since it is explicitly about GdImage|resource being used.
includes/admin/load.php
Outdated
| * Callback function to handle admin inline style. | ||
| * | ||
| * @since 3.0.0 | ||
| * @phpstan-ignore void.pure (PHPStan isn't apparently aware that this function is printing anything. See https://github.com/phpstan/phpstan/issues/11008) |
There was a problem hiding this comment.
PHPStan 1.11.1 was just released, fixing this.
swissspidy
left a comment
swissspidy
left a comment
There was a problem hiding this comment.
Let's update to 1.11.1 and then it should be good to go
Fixes #1209
See #775