Added server timing to REST API response#1206
Merged
westonruter merged 13 commits intoWordPress:trunkfrom May 14, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
swissspidy
requested review from
adamsilverstein,
joemcgill,
mukeshpanchal27,
swissspidy and
westonruter
westonruter
requested changes
May 7, 2024
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
…winparthasarathi/performance into update/add-server-timing-in-rest-api
Co-authored-by: Weston Ruter <[email protected]>
mukeshpanchal27
added
[Type] Enhancement
Co-authored-by: Mukesh Panchal <[email protected]>
Co-authored-by: Mukesh Panchal <[email protected]>
joemcgill
requested changes
May 9, 2024
Member
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Thanks! I've left a lot of feedback, but the only real blocking issue I see is the function name being introduced.
Contributor
Author
ashwinparthasarathi
left a comment
ashwinparthasarathi
left a comment
There was a problem hiding this comment.
Changed code based on review comments.
westonruter
reviewed
May 13, 2024
Updated header value for Server-Timing Co-authored-by: Weston Ruter <[email protected]>
westonruter
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1149
Relevant technical choices
Updated the core plugin to add ServerTiming to WP REST API end-points as well
How to test
Before the change is introduced,
After the change,
props: @swissspidy for the code.