Skip to content

Update PHPStan level to 5 #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 6 commits into from
May 7, 2024
Merged

Update PHPStan level to 5 #1202

westonruter merged 6 commits into from
May 7, 2024

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented May 6, 2024 •
edited
Loading

See #775.

This fixes the following PHPStan issues:

[ERROR] Found 11 errors 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/includes/server-timing/perflab-server-timing-tests.php                                                                                                                                   
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  111    Parameter #2 $args of method Perflab_Server_Timing::register_metric() expects array{measure_callback: callable(): mixed, access_cap: string}, array{access_cap: 'exist'} given.                
         💡 Array does not have offset 'measure_callback'.                                                                                                                                              
  122    Parameter #2 $args of method Perflab_Server_Timing::register_metric() expects array{measure_callback: callable(): mixed, access_cap: string}, array{measure_callback: '__return_null'} given.  
         💡 Array does not have offset 'access_cap'.                                                                                                                                                    
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   tests/includes/site-health/audit-autoloaded-options/audit-autoloaded-options-test.php                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  27     Parameter #1 $tests of function perflab_aao_add_autoloaded_options_test expects array{direct: array<string, array{label: string, test: string}>}, array{} given.  
         💡 Array does not have offset 'direct'.                                                                                                                           
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------ 
  Line   tests/includes/site-health/audit-enqueued-assets/audit-enqueued-assets-helper-test.php                      
 ------ ------------------------------------------------------------------------------------------------------------ 
  93     Parameter #1 $resource_url of function perflab_aea_get_path_from_resource_url expects string, false given.  
 ------ ------------------------------------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/includes/site-health/audit-enqueued-assets/audit-enqueued-assets-test.php                                                                                
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  168    Parameter #1 $tests of function perflab_aea_add_enqueued_assets_test expects array{direct: array<string, array{label: string, test: string}>}, array{} given.  
         💡 Array does not have offset 'direct'.                                                                                                                        
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   tests/plugins/auto-sizes/auto-sizes-test.php                                      
 ------ ---------------------------------------------------------------------------------- 
  49     Parameter #3 $icon of function wp_get_attachment_image expects bool, null given.  
  61     Parameter #3 $icon of function wp_get_attachment_image expects bool, null given.  
 ------ ---------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------ 
  Line   tests/plugins/dominant-color-images/dominant-color-test.php                         
 ------ ------------------------------------------------------------------------------------ 
  237    Parameter #3 $icon of function wp_get_attachment_image expects bool, string given.  
 ------ ------------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/webp-uploads/image-edit-tests.php                                                                                              
 ------ --------------------------------------------------------------------------------------------------------------------------------------------- 
  400    Parameter #2 $hashed_size_name of method PerformanceLab\Tests\TestCase\ImagesTestCase::assertSizeNameIsHashed() expects string, null given.  
 ------ --------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------ 
  Line   tests/plugins/webp-uploads/load-tests.php                                                                         
 ------ ------------------------------------------------------------------------------------------------------------------ 
  653    Parameter #1 $needle of method PHPUnit\Framework\Assert::assertStringContainsString() expects string, int given.  
  654    Parameter #1 $needle of method PHPUnit\Framework\Assert::assertStringContainsString() expects string, int given.  
 ------ ------------------------------------------------------------------------------------------------------------------

Please review individual commits for changes.

@westonruter westonruter added the [Type] Bug An existing feature is broken label May 6, 2024
@westonruter westonruter added this to the performance-lab 3.1.0 milestone May 6, 2024
@westonruter westonruter marked this pull request as ready for review May 6, 2024 21:27
@westonruter westonruter requested a review from thelovekesh May 6, 2024 21:27
@github-actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This was referenced May 6, 2024
Merged
Closed
mukeshpanchal27
mukeshpanchal27 approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

tests/includes/server-timing/perflab-server-timing-tests.php Outdated

$this->server_timing->register_metric(
'metric-without-measure-callback',
// @phpstan-ignore-next-line
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add note here why we ignore it?

Copy link
Member Author

@westonruter westonruter May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Added in c588e58

Base automatically changed from update/phpstan-level-4 to trunk May 7, 2024 16:35
@westonruter westonruter merged commit 837ad90 into trunk May 7, 2024
thelovekesh
thelovekesh approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@thelovekesh thelovekesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

phpstan.neon.dist
level: 4
level: 5
treatPhpDocTypesAsCertain: false
rememberPossiblyImpureFunctionValues: false
Copy link
Member

@thelovekesh thelovekesh May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if it had some doc reference on why this option was added?

Copy link
Member Author

@westonruter westonruter May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Merged before I saw this. Yes, good idea. Added in 0cd8565. I'll add a commit to #1203 to explain.

Copy link
Member Author

@westonruter westonruter May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b86637e

@westonruter westonruter deleted the update/phpstan-level-5 branch May 7, 2024 16:43
@westonruter westonruter added the skip changelog PRs that should not be mentioned in changelogs label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@thelovekesh thelovekesh thelovekesh approved these changes

@pbearne pbearne Awaiting requested review from pbearne

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@felixarntz felixarntz Awaiting requested review from felixarntz

@joemcgill joemcgill Awaiting requested review from joemcgill

@manuelRod manuelRod Awaiting requested review from manuelRod

Assignees

No one assigned

Labels

skip changelog PRs that should not be mentioned in changelogs [Type] Bug An existing feature is broken

Projects

None yet

Milestone

performance-lab 3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@westonruter @mukeshpanchal27 @thelovekesh