Skip to content

Guard against infinite recursion #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsilverstein wants to merge 3 commits into from
Closed

Guard against infinite recursion #1197

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b83949
Guard against infinite recursion
adamsilverstein May 1, 2024
cf3b298
Update includes/admin/plugins.php
adamsilverstein May 2, 2024
14c36cb
Update includes/admin/plugins.php
adamsilverstein May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions includes/admin/plugins.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ function perflab_render_plugins_ui() {
<?php
}

global $perflab_get_plugin_availability_plugins_checked;

/**
* Checks if a given plugin is available.
*
Expand All @@ -161,6 +163,13 @@ function perflab_render_plugins_ui() {
* @return array{compatible_php: bool, compatible_wp: bool, can_install: bool, can_activate: bool} Availability.
*/
function perflab_get_plugin_availability( array $plugin_data ): array {
global $perflab_get_plugin_availability_plugins_checked;
if ( empty( $perflab_get_plugin_availability_plugins_checked ) ) {
$perflab_get_plugin_availability_plugins_checked = array();
}
if ( ! empty( $perflab_get_plugin_availability_plugins_checked[ $plugin_data['slug'] ] ) ) {
return $perflab_get_plugin_availability_plugins_checked[ $plugin_data['slug'] ];
}
$availability = array(
'compatible_php' => (
! $plugin_data['requires_php'] ||
Expand Down Expand Up @@ -198,9 +207,13 @@ function perflab_get_plugin_availability( array $plugin_data ): array {
}
}

$perflab_get_plugin_availability_plugins_checked[ $plugin_data['slug'] ] = $availability;

return $availability;
}

global $perflab_install_and_activate_plugin_plugins_activated;

/**
* Installs and activates a plugin by its slug.
*
Expand All @@ -213,6 +226,10 @@ function perflab_get_plugin_availability( array $plugin_data ): array {
* @return WP_Error|null WP_Error on failure.
*/
function perflab_install_and_activate_plugin( string $plugin_slug ): ?WP_Error {
global $perflab_install_and_activate_plugin_plugins_activated;
if ( isset( $perflab_install_and_activate_plugin_plugins_activated[ $plugin_slug ] ) ) {
return null;
}
$plugin_data = perflab_query_plugin_info( $plugin_slug );
if ( $plugin_data instanceof WP_Error ) {
return $plugin_data;
Expand Down Expand Up @@ -268,6 +285,11 @@ function perflab_install_and_activate_plugin( string $plugin_slug ): ?WP_Error {
}
}

if ( empty( $perflab_install_and_activate_plugin_plugins_activated ) ) {
$perflab_install_and_activate_plugin_plugins_activated = array();
}
$perflab_install_and_activate_plugin_plugins_activated[ $plugin_slug ] = true;

return null;
}

Expand Down