Fix PHPStan issues in Optimization Detective #1195

westonruter · 2024-05-01T01:00:59Z

Part of #775.

Almost all of the changes here are trivial changes to test files.

The changes in this PR resolve the following PHPStan issues to bring the level to 6:

PHPStan Output

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/class-od-html-tag-walker-tests.php                                                                        
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 
  19     Method OD_HTML_Tag_Walker_Tests::data_provider_sample_documents() return type has no value type specified in iterable type array.              
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                      
  305    Method OD_HTML_Tag_Walker_Tests::test_open_tags_and_get_xpath() has no return type specified.                                                  
  305    Method OD_HTML_Tag_Walker_Tests::test_open_tags_and_get_xpath() has parameter $open_tags with no value type specified in iterable type array.  
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                      
  305    Method OD_HTML_Tag_Walker_Tests::test_open_tags_and_get_xpath() has parameter $xpaths with no value type specified in iterable type array.     
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                      
  325    Method OD_HTML_Tag_Walker_Tests::test_append_head_html() has no return type specified.                                                         
  373    Method OD_HTML_Tag_Walker_Tests::test_append_head_and_body_html() has no return type specified.                                                
  433    Method OD_HTML_Tag_Walker_Tests::test_html_tag_processor_wrapper_methods() has no return type specified.                                       
  448    Method OD_HTML_Tag_Walker_Tests::export_array_snapshot() has parameter $data with no value type specified in iterable type array.              
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                      
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/class-od-url-metric-tests.php                                                       
 ------ ------------------------------------------------------------------------------------------------------------------------- 
  16     Method OD_URL_Metric_Tests::data_provider() return type has no value type specified in iterable type array.              
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                
  126    Method OD_URL_Metric_Tests::test_constructor() has no return type specified.                                             
  126    Method OD_URL_Metric_Tests::test_constructor() has parameter $data with no value type specified in iterable type array.  
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                
  144    Method OD_URL_Metric_Tests::test_get_json_schema() has no return type specified.                                         
 ------ ------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/class-od-url-metrics-group-collection-tests.php                                                                                                     
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  19     Method OD_URL_Metrics_Group_Collection_Tests::data_provider_test_construction() return type has no value type specified in iterable type array.                                          
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  95     Method OD_URL_Metrics_Group_Collection_Tests::test_construction() has no return type specified.                                                                                          
  95     Method OD_URL_Metrics_Group_Collection_Tests::test_construction() has parameter $breakpoints with no value type specified in iterable type array.                                        
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  95     Method OD_URL_Metrics_Group_Collection_Tests::test_construction() has parameter $url_metrics with no value type specified in iterable type array.                                        
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  108    Method OD_URL_Metrics_Group_Collection_Tests::data_provider_sample_size_and_breakpoints() return type has no value type specified in iterable type array.                                
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  179    Method OD_URL_Metrics_Group_Collection_Tests::test_add_url_metric() has no return type specified.                                                                                        
  179    Method OD_URL_Metrics_Group_Collection_Tests::test_add_url_metric() has parameter $breakpoints with no value type specified in iterable type array.                                      
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  209    Method OD_URL_Metrics_Group_Collection_Tests::test_adding_pushes_out_old_metrics() has no return type specified.                                                                         
  222    Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,            
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:       
         string, timestamp: float, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool, isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect:  
         array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>} given.                                                                                             
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                                  
  259    Method OD_URL_Metrics_Group_Collection_Tests::data_provider_test_get_iterator() return type has no value type specified in iterable type array.                                          
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  308    Method OD_URL_Metrics_Group_Collection_Tests::test_get_iterator() has no return type specified.                                                                                          
  308    Method OD_URL_Metrics_Group_Collection_Tests::test_get_iterator() has parameter $breakpoints with no value type specified in iterable type array.                                        
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  308    Method OD_URL_Metrics_Group_Collection_Tests::test_get_iterator() has parameter $expected_groups with no value type specified in iterable type array.                                    
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  308    Method OD_URL_Metrics_Group_Collection_Tests::test_get_iterator() has parameter $viewport_widths with no value type specified in iterable type array.                                    
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  346    Method OD_URL_Metrics_Group_Collection_Tests::data_provider_test_get_group_for_viewport_width() return type has no value type specified in iterable type array.                          
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  356    Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,            
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:       
         string, timestamp: float, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool, isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect:  
         array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>} given.                                                                                             
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                                  
  366    Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,            
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:       
         string, timestamp: float, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool, isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect:  
         array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>} given.                                                                                             
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                                  
  467    Method OD_URL_Metrics_Group_Collection_Tests::test_get_group_for_viewport_width() has no return type specified.                                                                          
  467    Method OD_URL_Metrics_Group_Collection_Tests::test_get_group_for_viewport_width() has parameter $breakpoints with no value type specified in iterable type array.                        
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  467    Method OD_URL_Metrics_Group_Collection_Tests::test_get_group_for_viewport_width() has parameter $expected_is_group_complete with no value type specified in iterable type array.         
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  467    Method OD_URL_Metrics_Group_Collection_Tests::test_get_group_for_viewport_width() has parameter $expected_return with no value type specified in iterable type array.                    
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  467    Method OD_URL_Metrics_Group_Collection_Tests::test_get_group_for_viewport_width() has parameter $url_metrics with no value type specified in iterable type array.                        
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                                
  497    Method OD_URL_Metrics_Group_Collection_Tests::test_is_every_group_populated() has no return type specified.                                                                              
  532    Method OD_URL_Metrics_Group_Collection_Tests::test_get_flattened_url_metrics() has no return type specified.                                                                             
  579    Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,            
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:       
         string, viewport: array{width: int, height: 640}, timestamp: float, elements: array{array{isLCP: true, isLCPCandidate: true, xpath: '/*[0][self::HTML]/*…', intersectionRatio: 1}}}      
         given.                                                                                                                                                                                   
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                                  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   tests/plugins/optimization-detective/class-od-url-metrics-group-tests.php                                                                                                           
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  20     Method OD_URL_Metrics_Group_Tests::data_provider_test_construction() return type has no value type specified in iterable type array.                                                
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  73     Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,       
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:  
         string, viewport: array{width: 1, height: 2}, timestamp: float, elements: array{}} given.                                                                                           
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                             
  102    Method OD_URL_Metrics_Group_Tests::test_construction() has no return type specified.                                                                                                
  102    Method OD_URL_Metrics_Group_Tests::test_construction() has parameter $url_metrics with no value type specified in iterable type array.                                              
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  120    Method OD_URL_Metrics_Group_Tests::data_provider_test_is_viewport_width_in_range() return type has no value type specified in iterable type array.                                  
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  155    Method OD_URL_Metrics_Group_Tests::test_is_viewport_width_in_range() has no return type specified.                                                                                  
  155    Method OD_URL_Metrics_Group_Tests::test_is_viewport_width_in_range() has parameter $viewport_widths_expected with no value type specified in iterable type array.                   
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  167    Method OD_URL_Metrics_Group_Tests::data_provider_test_add_url_metric() return type has no value type specified in iterable type array.                                              
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  186    Method OD_URL_Metrics_Group_Tests::test_add_url_metric() has no return type specified.                                                                                              
  195    Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,       
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:  
         string, viewport: array{width: int, height: 1000}, timestamp: float, elements: array{}} given.                                                                                      
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ -------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/detection-tests.php                                                
 ------ -------------------------------------------------------------------------------------------------------- 
  57     Method OD_Detection_Tests::test_od_get_detection_script_returns_script() has no return type specified.  
 ------ -------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/helper-tests.php                                      
 ------ ------------------------------------------------------------------------------------------- 
  15     Method OD_Helper_Tests::test_od_render_generator_meta_tag() has no return type specified.  
 ------ ------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/hooks-tests.php                     
 ------ ------------------------------------------------------------------------- 
  15     Method OD_Hooks_Tests::test_hooks_added() has no return type specified.  
 ------ ------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   tests/plugins/optimization-detective/optimization-tests.php                                                                                                                         
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  40     Method OD_Optimization_Tests::test_od_buffer_output() has no return type specified.                                                                                                 
  72     Method OD_Optimization_Tests::test_od_maybe_add_template_output_buffer_filter() has no return type specified.                                                                       
  92     Method OD_Optimization_Tests::data_provider_test_od_can_optimize_response() return type has no value type specified in iterable type array.                                         
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  155    Method OD_Optimization_Tests::test_od_can_optimize_response() has no return type specified.                                                                                         
  165    Method OD_Optimization_Tests::data_provider_test_od_construct_preload_links() return type has no value type specified in iterable type array.                                       
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  302    Method OD_Optimization_Tests::test_od_construct_preload_links() has no return type specified.                                                                                       
  302    Method OD_Optimization_Tests::test_od_construct_preload_links() has parameter $lcp_elements_by_minimum_viewport_widths with no value type specified in iterable type array.         
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  314    Method OD_Optimization_Tests::data_provider_test_od_optimize_template_output_buffer() return type has no value type specified in iterable type array.                               
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  1021   Method OD_Optimization_Tests::test_od_optimize_template_output_buffer() has no return type specified.                                                                               
  1057   Method OD_Optimization_Tests::get_validated_url_metric() has parameter $elements with no value type specified in iterable type array.                                               
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  1078   Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,       
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:  
         string, viewport: array{width: int, height: 800}, timestamp: float, elements: array<non-empty-array>} given.                                                                        
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/storage/class-od-storage-lock-tests.php               
 ------ ------------------------------------------------------------------------------------------- 
  66     Method OD_Storage_Lock_Tests::test_get_ttl() has no return type specified.                 
  76     Method OD_Storage_Lock_Tests::test_get_transient_key() has no return type specified.       
  98     Method OD_Storage_Lock_Tests::test_set_lock_and_is_locked() has no return type specified.  
 ------ ------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/storage/class-od-url-metrics-post-type-tests.php                                                                                                
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  18     Method OD_Storage_Post_Type_Tests::test_add_hooks() has no return type specified.                                                                                                    
  44     Method OD_Storage_Post_Type_Tests::test_register_post_type() has no return type specified.                                                                                           
  57     Method OD_Storage_Post_Type_Tests::test_od_post_when_absent() has no return type specified.                                                                                          
  67     Method OD_Storage_Post_Type_Tests::test_od_post_when_present() has no return type specified.                                                                                         
  87     Method OD_Storage_Post_Type_Tests::data_provider_test_get_url_metrics_from_post() return type has no value type specified in iterable type array.                                    
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                            
  127    Method OD_Storage_Post_Type_Tests::test_get_url_metrics_from_post() has no return type specified.                                                                                    
  127    Method OD_Storage_Post_Type_Tests::test_get_url_metrics_from_post() has parameter $expected_value with no value type specified in iterable type array.                               
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                            
  150    Method OD_Storage_Post_Type_Tests::test_store_url_metric() has no return type specified.                                                                                             
  177    Method OD_Storage_Post_Type_Tests::test_schedule_garbage_collection_logged_out() has no return type specified.                                                                       
  187    Method OD_Storage_Post_Type_Tests::test_schedule_garbage_collection_first_log_in() has no return type specified.                                                                     
  200    Method OD_Storage_Post_Type_Tests::test_schedule_garbage_collection_reschedule() has no return type specified.                                                                       
  214    Method OD_Storage_Post_Type_Tests::test_delete_stale_posts() has no return type specified.                                                                                           
  259    Method OD_Storage_Post_Type_Tests::test_delete_all_posts() has no return type specified.                                                                                             
  334    Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,        
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:   
         string, viewport: array{width: 480, height: 640}, timestamp: float, elements: array{array{isLCP: true, isLCPCandidate: true, xpath: '/*[0][self::HTML]/*…', intersectionRatio: 1}}}  
         given.                                                                                                                                                                               
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                              
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   tests/plugins/optimization-detective/storage/data-tests.php                                                                                                                         
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  33     Method OD_Storage_Data_Tests::test_od_get_url_metric_freshness_ttl() has no return type specified.                                                                                  
  52     Method OD_Storage_Data_Tests::test_bad_od_get_url_metric_freshness_ttl() has no return type specified.                                                                              
  68     Method OD_Storage_Data_Tests::data_provider_test_od_get_normalized_query_vars() return type has no value type specified in iterable type array.                                     
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  129    Method OD_Storage_Data_Tests::test_od_get_normalized_query_vars() has no return type specified.                                                                                     
  139    Method OD_Storage_Data_Tests::data_provider_test_get_current_url() return type has no value type specified in iterable type array.                                                  
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  255    Method OD_Storage_Data_Tests::set_home_url_with_filter() has no return type specified.                                                                                              
  271    Method OD_Storage_Data_Tests::test_od_get_current_url() has no return type specified.                                                                                               
  280    Method OD_Storage_Data_Tests::test_od_get_url_metrics_slug() has no return type specified.                                                                                          
  295    Method OD_Storage_Data_Tests::test_od_get_url_metrics_storage_nonce_and_od_verify_url_metrics_storage_nonce() has no return type specified.                                         
  340    Method OD_Storage_Data_Tests::test_od_get_breakpoint_max_widths() has no return type specified.                                                                                     
  365    Method OD_Storage_Data_Tests::data_provider_test_bad_od_get_breakpoint_max_widths() return type has no value type specified in iterable type array.                                 
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  394    Method OD_Storage_Data_Tests::test_bad_od_get_breakpoint_max_widths() has no return type specified.                                                                                 
  394    Method OD_Storage_Data_Tests::test_bad_od_get_breakpoint_max_widths() has parameter $breakpoints with no value type specified in iterable type array.                               
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  394    Method OD_Storage_Data_Tests::test_bad_od_get_breakpoint_max_widths() has parameter $expected with no value type specified in iterable type array.                                  
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  410    Method OD_Storage_Data_Tests::test_od_get_url_metrics_breakpoint_sample_size() has no return type specified.                                                                        
  429    Method OD_Storage_Data_Tests::test_bad_od_get_url_metrics_breakpoint_sample_size() has no return type specified.                                                                    
  446    Method OD_Storage_Data_Tests::data_provider_test_get_lcp_elements_by_minimum_viewport_widths() return type has no value type specified in iterable type array.                      
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  519    Method OD_Storage_Data_Tests::test_get_lcp_elements_by_minimum_viewport_widths() has no return type specified.                                                                      
  519    Method OD_Storage_Data_Tests::test_get_lcp_elements_by_minimum_viewport_widths() has parameter $breakpoints with no value type specified in iterable type array.                    
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  519    Method OD_Storage_Data_Tests::test_get_lcp_elements_by_minimum_viewport_widths() has parameter $expected_lcp_element_xpaths with no value type specified in iterable type array.    
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  519    Method OD_Storage_Data_Tests::test_get_lcp_elements_by_minimum_viewport_widths() has parameter $url_metrics with no value type specified in iterable type array.                    
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                                                           
  528    Offset 'isLCP' does not exist on array{xpath: string}.                                                                                                                              
  568    Parameter #1 $data of class OD_URL_Metric constructor expects array{url: string, timestamp: int, viewport: array{width: int, height: int}, elements: array<array{isLCP: bool,       
         isLCPCandidate: bool, xpath: string, intersectionRatio: float, intersectionRect: array{width: int, height: int}, boundingClientRect: array{width: int, height: int}}>}, array{url:  
         string, viewport: array{width: int, height: 640}, timestamp: float, elements: array{array{isLCP: bool, isLCPCandidate: bool, xpath: string, intersectionRatio: 1}}} given.          
         💡 Offset 'timestamp' (int) does not accept type float.                                                                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/storage/rest-api-tests.php                                                                              
 ------ --------------------------------------------------------------------------------------------------------------------------------------------- 
  20     Method OD_Storage_REST_API_Tests::test_od_register_endpoint_hooked() has no return type specified.                                           
  30     Method OD_Storage_REST_API_Tests::test_rest_request_good_params() has no return type specified.                                              
  56     Method OD_Storage_REST_API_Tests::data_provider_invalid_params() return type has no value type specified in iterable type array.             
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
  132    Method OD_Storage_REST_API_Tests::test_rest_request_bad_params() has no return type specified.                                               
  132    Method OD_Storage_REST_API_Tests::test_rest_request_bad_params() has parameter $params with no value type specified in iterable type array.  
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
  148    Method OD_Storage_REST_API_Tests::test_rest_request_timestamp_ignored() has no return type specified.                                        
  179    Method OD_Storage_REST_API_Tests::test_rest_request_locked() has no return type specified.                                                   
  196    Method OD_Storage_REST_API_Tests::test_rest_request_breakpoint_not_needed_for_any_breakpoint() has no return type specified.                 
  222    Method OD_Storage_REST_API_Tests::test_rest_request_breakpoint_not_needed_for_specific_breakpoint() has no return type specified.            
  247    Method OD_Storage_REST_API_Tests::test_rest_request_over_populate_wider_viewport_group() has no return type specified.                       
  303    Method OD_Storage_REST_API_Tests::test_rest_request_over_populate_narrower_viewport_group() has no return type specified.                    
  338    Method OD_Storage_REST_API_Tests::populate_url_metrics() has no return type specified.                                                       
  338    Method OD_Storage_REST_API_Tests::populate_url_metrics() has parameter $params with no value type specified in iterable type array.          
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
  353    Method OD_Storage_REST_API_Tests::get_valid_params() has parameter $extras with no value type specified in iterable type array.              
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
  353    Method OD_Storage_REST_API_Tests::get_valid_params() return type has no value type specified in iterable type array.                         
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
  379    Method OD_Storage_REST_API_Tests::recursive_merge() has parameter $base_array with no value type specified in iterable type array.           
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
  379    Method OD_Storage_REST_API_Tests::recursive_merge() has parameter $sparse_array with no value type specified in iterable type array.         
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
  379    Method OD_Storage_REST_API_Tests::recursive_merge() return type has no value type specified in iterable type array.                          
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
  399    Method OD_Storage_REST_API_Tests::get_sample_validated_url_metric() return type has no value type specified in iterable type array.          
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                                    
 ------ --------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/uninstall-tests.php                       
 ------ ------------------------------------------------------------------------------- 
  26     Method OD_Uninstall_Tests::require_uninstall() has no return type specified.   
  33     Method OD_Uninstall_Tests::test_post_deletion() has no return type specified.  
  48     Method OD_Uninstall_Tests::test_event_removal() has no return type specified.  
 ------ -------------------------------------------------------------------------------

This is the config used:

PHPStan Config

includes:
	- phar://phpstan.phar/conf/bleedingEdge.neon
parameters:
	level: 6
	paths:
		- load.php
		- plugins/
		- includes/
		- tests/
	treatPhpDocTypesAsCertain: false
	checkGenericClassInNonGenericObjectType: false
	scanDirectories:
		- vendor/wp-phpunit/wp-phpunit/
	ignoreErrors:
		# These don't work in PhpStorm due to https://youtrack.jetbrains.com/issue/WI-63891
		# False positive as WordPress ships with a polyfill.
		-
			message: "#^Function str_starts_with not found\\.$#"
			paths:
				- load.php
				- plugins/optimization-detective/optimization.php
				- plugins/speculation-rules/class-plsr-url-pattern-prefixer.php
		-
			message: "#^Function str_contains not found\\.$#"
			paths:
				- plugins/auto-sizes/hooks.php
				- plugins/dominant-color-images/hooks.php

	dynamicConstantNames:
		- PERFLAB_OBJECT_CACHE_DROPIN_VERSION
		- WP_DEBUG_DISPLAY

	bootstrapFiles:
		- load.php
		- bin/phpstan/constants.php
		- plugins/webp-uploads/load.php

github-actions · 2024-05-01T01:01:13Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: thelovekesh <[email protected]>
Co-authored-by: joemcgill <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

… fix/optimization-detective-phpstan * 'trunk' of https://github.com/WordPress/performance: Fix minor issues Enqueue a11y script Add a11y message Apply suggestions from code review Add empty line Add Progress indicator Make variable name more explicit Facilitate embedding Optimization Detective in other plugins/themes

…ive-phpstan * fix/xpath-starting-number:

thelovekesh

LGTM!

westonruter added 3 commits April 30, 2024 10:43

Fix typing for static analysis

aa7404d

Fix type of timestamp to be float

61b185d

Fix typing issues

7f8f30c

westonruter added [Type] Bug An existing feature is broken [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels May 1, 2024

westonruter added this to the optimization-detective n.e.x.t milestone May 1, 2024

westonruter requested a review from mukeshpanchal27 May 1, 2024 01:00

westonruter requested a review from felixarntz as a code owner May 1, 2024 01:01

westonruter force-pushed the fix/xpath-starting-number branch from aa7404d to 733bb3e Compare May 1, 2024 01:01

westonruter mentioned this pull request May 1, 2024

Fix XPath indices to be 1-based instead of 0-based #1191

Merged

westonruter added 3 commits April 30, 2024 22:04

Fix static analysis issues in OD tests

7775096

Add missing OD constants to phpstan/constants.php

e75ea11

westonruter requested a review from thelovekesh May 1, 2024 05:09

Merge branch 'fix/xpath-starting-number' into fix/optimization-detect…

bb5492c

…ive-phpstan * fix/xpath-starting-number:

Base automatically changed from fix/xpath-starting-number to trunk May 1, 2024 05:53

Merge branch 'trunk' into fix/optimization-detective-phpstan

46ba7c8

westonruter mentioned this pull request May 3, 2024

Improve static analysis in Performance Lab plugin files #1188

Merged

thelovekesh approved these changes May 3, 2024

View reviewed changes

westonruter requested a review from adamsilverstein May 3, 2024 17:49

joemcgill approved these changes May 3, 2024

View reviewed changes

Merge branch 'trunk' into fix/optimization-detective-phpstan

32f6ec6

westonruter merged commit b80dd39 into trunk May 3, 2024
21 checks passed

westonruter deleted the fix/optimization-detective-phpstan branch May 3, 2024 18:40

westonruter mentioned this pull request May 4, 2024

Increase PHPStan to rule level to 1 (and beyond) #775

Closed

12 tasks

westonruter added the skip changelog PRs that should not be mentioned in changelogs label May 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PHPStan issues in Optimization Detective #1195

Fix PHPStan issues in Optimization Detective #1195

westonruter commented May 1, 2024 •

edited by thelovekesh

Loading

github-actions bot commented May 1, 2024 •

edited

Loading

thelovekesh left a comment

Fix PHPStan issues in Optimization Detective #1195

Fix PHPStan issues in Optimization Detective #1195

Conversation

westonruter commented May 1, 2024 • edited by thelovekesh Loading

github-actions bot commented May 1, 2024 • edited Loading

thelovekesh left a comment

Choose a reason for hiding this comment

westonruter commented May 1, 2024 •

edited by thelovekesh

Loading

github-actions bot commented May 1, 2024 •

edited

Loading