Fix XPath indices to be 1-based instead of 0-based #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
force-pushed
the
fix/xpath-starting-number
branch
from
aa7404d to
733bb3e
Compare
… fix/xpath-starting-number * 'trunk' of https://github.com/WordPress/performance: Fix minor issues Enqueue a11y script Add a11y message Apply suggestions from code review Add empty line Add Progress indicator Make variable name more explicit Facilitate embedding Optimization Detective in other plugins/themes
swissspidy
approved these changes
May 1, 2024
thelovekesh
approved these changes
May 1, 2024
This was referenced Aug 22, 2024
westonruter
added a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1124
The test changes are pretty much all just increasing the XPath indices to start from 1 instead of 0.
Also, aa7404d fixes some typing issues withMoved to #1195.\OD_Optimization_Tests::get_validated_url_metric().