Add Progress indicator when activating a feature#1190
Conversation
mukeshpanchal27
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mukeshpanchal27
requested review from
joemcgill,
swissspidy,
thelovekesh and
westonruter
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Wow, so nice!
Screen.recording.2024-04-29.22.15.19.webm
|
@mukeshpanchal27 this works in WP 6.4 as well, yes? |
Yes, it works fine in 6.4. |
mukeshpanchal27
removed
the
no milestone
| sprintf( | ||
| '( %s )( %s );', | ||
| $js_function, | ||
| wp_json_encode( __( 'Activating…', 'default' ) ) |
There was a problem hiding this comment.
I just realized that this is 'Activating…' when the core string appears to rather be 'Activating...' (not using the ellipsis):
Does this need to be amended?
| target.classList.add( 'updating-message' ); | ||
| target.textContent = message; | ||
|
|
||
| wp.a11y.speak(message); |
There was a problem hiding this comment.
Nit: Add spacing around the message param
| * | ||
| * @since n.e.x.t | ||
| */ | ||
| function perflab_print_plugin_progress_indicator_script() { |
There was a problem hiding this comment.
Also, per #1188, might as well explicitly make this return void:
function perflab_print_plugin_progress_indicator_script(): void {3 participants
Summary
Fixes #1139