Skip to content

Facilitate embedding Optimization Detective in other plugins/themes #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 2 commits into from
Apr 30, 2024
Merged

Facilitate embedding Optimization Detective in other plugins/themes #1185

westonruter merged 2 commits into from
Apr 30, 2024

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Apr 29, 2024 •
edited
Loading

Fixes #1081

This copies the exact same boilerplate bootstrap logic as was implemented for Speculative Loading in #1159.

Review with whitespace changes suppressed: https://github.com/WordPress/performance/pull/1185/files?diff=unified&w=1

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels Apr 29, 2024
@westonruter westonruter requested a review from felixarntz as a code owner April 29, 2024 15:56
@github-actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: joemcgill <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

joemcgill
joemcgill approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.

westonruter
westonruter commented Apr 29, 2024
View reviewed changes
adamsilverstein
adamsilverstein approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@westonruter westonruter merged commit 45f088c into trunk Apr 30, 2024
@westonruter westonruter deleted the add/faciliate-od-embedding branch April 30, 2024 15:54
@westonruter westonruter mentioned this pull request Oct 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemcgill joemcgill joemcgill approved these changes

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz felixarntz is a code owner

Assignees

No one assigned

Labels

[Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

optimization-detective 0.2.0

Development

Successfully merging this pull request may close these issues.

Facilitate Optimization Detective to be embedded in other plugins/themes

4 participants

@westonruter @joemcgill @adamsilverstein