Use PHP 7.2 features in Optimization Detective #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
thelovekesh
approved these changes
Apr 19, 2024
joemcgill
approved these changes
Apr 19, 2024
Member
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Just one suggestion, but looks good. Pre-approving.
| * @link https://core.trac.wordpress.org/ticket/43258 | ||
| * | ||
| * @param string $passthrough Optional. Filter value. Default null. | ||
| * @param string $passthrough Value for the template_include filter which is passed through. |
Co-authored-by: Joe McGill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1130 the PHP version was bumped to 7.2. This allows us to make use of new PHP language features which further harden static analysis (related to #775). Changes in this PR include:
voidreturn type#^(Function|Method) .+? return type has no value type specified in iterable type array##^(Function|Method) .+? has parameter .+? with no value type specified in iterable type array##^(Function|Method) .+? has no return type specified#