Skip to content

Add settings link to Speculative Loading plugin action links #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 3 commits into from
Apr 16, 2024
Merged

Add settings link to Speculative Loading plugin action links #1145

swissspidy merged 3 commits into from
Apr 16, 2024

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Apr 16, 2024 •
edited
Loading

Fixes #1131

image

@westonruter westonruter added the [Type] Enhancement A suggestion for improvement of an existing feature label Apr 16, 2024
@westonruter westonruter added this to the speculation-rules n.e.x.t milestone Apr 16, 2024
@westonruter westonruter requested a review from felixarntz as a code owner April 16, 2024 00:11
@github-actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: thelovekesh <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter force-pushed the add/speculative-loading-settings-link branch from f23e46f to b7a6634 Compare April 16, 2024 00:16
@westonruter westonruter mentioned this pull request Apr 16, 2024
Merged
@swissspidy swissspidy merged commit dbc763f into trunk Apr 16, 2024
@swissspidy swissspidy deleted the add/speculative-loading-settings-link branch April 16, 2024 06:15
@westonruter westonruter mentioned this pull request Apr 17, 2024
Closed
@westonruter westonruter mentioned this pull request Jul 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@thelovekesh thelovekesh thelovekesh approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz felixarntz is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees

No one assigned

Labels

[Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

speculation-rules 1.2.1

Development

Successfully merging this pull request may close these issues.

Settings link missing from Speculative Loading plugin row actions

5 participants

@westonruter @mukeshpanchal27 @thelovekesh @swissspidy