Conversation
felixarntz
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Looks good to me. Pre-approving with one suggestion.
| * | ||
| * @covers ::auto_sizes_render_generator | ||
| */ | ||
| public function test_auto_sizes_render_generator() { |
There was a problem hiding this comment.
I'd be for adding an additional test to ensure this callback is properly hooked to the wp_head action, similar to this example.
There was a problem hiding this comment.
Fair point, we can add this here. Though then I'd say lets also assert the other hooks in the same test.
|
There's an unrelated "Spell Check" CI failure here now, for which I opened #1106. Please take a look. |
The PR has been merged now, and the CI failure has also been fixed in this branch. It's ready for merge. |
4 participants
Summary
This PR adds a generator meta tag to the remaining plugin that didn't have one yet,
auto-sizes. Per #1103, it uses the immutable plugin slug for it.This will be included in the 1.0.1 version (for which the codebase has already been bumped before).