-
Notifications
You must be signed in to change notification settings - Fork 138
Remove modules infrastructure and UI from the plugin #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3ced295
Initial changes
mukeshpanchal27 00e660b
Minor updates
mukeshpanchal27 66f0492
Address review feedback
mukeshpanchal27 dde4df9
Resolve merge conflict
mukeshpanchal27 079088b
Minor updates
mukeshpanchal27 3d406e5
Remove PERFLAB_MODULES_SETTING
mukeshpanchal27 988aabc
Add missing end line
mukeshpanchal27 59c96e5
Update page slug and delete settings option
mukeshpanchal27 35384d8
Resolve merge conflict
mukeshpanchal27 cd9f564
Fix spell
mukeshpanchal27 959377c
Remove get_option call
mukeshpanchal27 fe8f9f6
Enhance testability of redirect.
felixarntz a91b3fb
Merge branch 'trunk' into fix/1030-remove-modules-infrastructure
felixarntz c40dde2
Remove extra whitespace.
felixarntz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the plugins no longer needing to be built? In
bin/plugin/commands/test-plugins.jsit is not accounting for assets which may have been generated by Webpack as it is just copying the source files from/pluginsto/build. It seems rather thattest-plugins.jsshould be updated to reuse the output fromnpm run build-pluginswhich is already outputting the plugins into/build. cc @thelovekeshThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing that out. It's on my list to address as a follow-up PR since it scratches the current one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what @thelovekesh wrote in #1060 (comment), do we even need this anymore? The purpose of the
test-pluginsscript and this GitHub workflow was purely to test whether standalone plugins don't cause some weird fatal error when built from their modules.Since we don't build modules into plugins anymore, I think this isn't useful any more. For that reason, I would suggest to remove the whole
test-pluginsscript and everything around it. Since this is only removing more things, it would be great if you could do it as part of this PR.I think some of the code changes in this PR are a bit confusing because they're changing those scripts when they don't really have a good purpose anymore as a whole.