Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow excluding URL patterns from prerendering or prefetching specifically #1025

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Allow excluding URL patterns from prerendering or prefetching specifically #1025

merged 4 commits into from
Mar 5, 2024

Conversation

felixarntz
Copy link
Member

Summary

Fixes #907

Relevant technical choices

  • Add new $mode parameter as defined in the issue.
  • Add documentation to readme FAQ.
  • Add test coverage.
  • Bump Speculation Rules plugin version to 1.1.0 to eventually release the enhancement.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] JS & CSS no milestone PRs that do not have a defined milestone for release [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules) labels Mar 4, 2024
westonruter
westonruter approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nit suggestions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @domenic.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: domenic.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 merged commit 9106478 into trunk Mar 5, 2024
39 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the enhance/907-mode-parameter branch March 5, 2024 04:22
@felixarntz felixarntz added this to the speculation-rules 1.1.0 milestone Mar 21, 2024
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@thelovekesh thelovekesh Awaiting requested review from thelovekesh

Assignees
No one assigned
Labels
[Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
speculation-rules 1.1.0
Development

Successfully merging this pull request may close these issues.

Allow certain URLs to opt out of prerendering while still eligible for prefetching
3 participants
@felixarntz @westonruter @mukeshpanchal27