-
Notifications
You must be signed in to change notification settings - Fork 138
Closed
Labels
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin onlyIssue relates to work in the Performance Lab Plugin only[Type] BugAn existing feature is brokenAn existing feature is broken
Milestone
Description
Bug Description
There closures being used in the codebase which do not use $this. Granted, in most cases clases aren't even involved, but in those that are, using static is better for memory usage since the $this reference can be garbage collected. See SO answer.
I suggest that we do the following:
- Add
staticto all closures that don't use$this. - Incorporate the
SlevomatCodingStandard.Functions.StaticClosuresniff to catch this automatically.
adamsilverstein
Metadata
Metadata
Assignees
Labels
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin onlyIssue relates to work in the Performance Lab Plugin only[Type] BugAn existing feature is brokenAn existing feature is broken