-
Notifications
You must be signed in to change notification settings - Fork 138
Closed
Labels
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure[Type] BugAn existing feature is brokenAn existing feature is broken
Description
The various JS-based command line utilities that access module files to parse out some information (npm run translations and npm run enabled-modules) currently do so in random order. While this is not a major problem, it's certainly inconvenient and undesirable, as it may introduce changes to the generated files without any of the actual data in there changing.
We should fix it, so that these commands always treat modules in the expected order, sorted as follows:
- By the order of the focus areas (see how they are defined in
perflab_get_focus_areas(). - By whether they are experimental or not (non-experimental modules come first).
- Alphabetically by module name.
For the implementation, we should be able to fix it for both commands by making sure this order is respected in the getModuleData( modulesDir ) JS function reused by both of them.
Metadata
Metadata
Assignees
Labels
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure[Type] BugAn existing feature is brokenAn existing feature is broken