Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST API endpoint for storing a URL Metric should return a 423 Locked status code instead of 403 Forbidden #1860

Closed
westonruter opened this issue Feb 11, 2025 · 1 comment · Fixed by #1863
Closed

REST API endpoint for storing a URL Metric should return a 423 Locked status code instead of 403 Forbidden #1860

westonruter opened this issue Feb 11, 2025 · 1 comment · Fixed by #1863
Assignees
@hbhalodia
Labels
[Plugin] Optimization Detective Issues for the Optimization Detective plugin
Milestone
optimization-dete...

Comments

@westonruter
Copy link
Member

See todo:

performance/plugins/optimization-detective/storage/rest-api.php

Lines 95 to 105 in 1f8265d

'permission_callback' => static function () {
// Needs to be available to unauthenticated visitors.
if ( OD_Storage_Lock::is_locked() ) {
return new WP_Error(
'url_metric_storage_locked',
__( 'URL Metric storage is presently locked for the current IP.', 'optimization-detective' ),
array( 'status' => 403 ) // TODO: Consider 423 Locked status code.
);
}
return true;
},

@westonruter westonruter added the [Plugin] Optimization Detective Issues for the Optimization Detective plugin label Feb 11, 2025
@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2025 Feb 11, 2025
@hbhalodia
Copy link
Contributor

Hi @westonruter, I would like to work on this issue and would update the status code for storing URL metric.

Thank You,

@hbhalodia hbhalodia mentioned this issue Feb 11, 2025
Merged
@westonruter westonruter moved this from Not Started/Backlog 📆 to Code Review 👀 in WP Performance 2025 Feb 11, 2025
@github-project-automation github-project-automation bot moved this from Code Review 👀 to Done 😃 in WP Performance 2025 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hbhalodia hbhalodia

Labels
[Plugin] Optimization Detective Issues for the Optimization Detective plugin
Projects
WP Performance 2025
Status: Done 😃
Milestone
optimization-detective 1.0.0-beta3
2 participants
@westonruter @hbhalodia