Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests with WordPress trunk #1532

Closed
felixarntz opened this issue Sep 12, 2024 · 2 comments · Fixed by #1533
Closed

Fix failing tests with WordPress trunk #1532

felixarntz opened this issue Sep 12, 2024 · 2 comments · Fixed by #1533
Assignees
@westonruter
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken
Milestone
webp-uploads 2.2.0

Comments

@felixarntz
Copy link
Member

Bug Description

See e.g. https://github.com/WordPress/performance/actions/runs/10820446352/job/30020524054?pr=1492: The PHPUnit tests fail, but that's entirely independent of that PR.

It looks like these failures are because we're looking at the exact img tag markup for the "Modern Image Formats" plugin, which of course was changed as of committing sizes="auto" to Core.

Steps to reproduce

You should see those failures as soon as you open any PR, or run unit tests locally against WordPress trunk.
@felixarntz felixarntz added [Type] Bug An existing feature is broken [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Sep 12, 2024
@felixarntz felixarntz added this to the webp-uploads n.e.x.t milestone Sep 12, 2024
@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2025 Sep 12, 2024
@felixarntz
Copy link
Member Author

@adamsilverstein @mukeshpanchal27 @joemcgill Could one of you please take a look at this, so we can unblock other PRs with these failing tests?

@felixarntz felixarntz mentioned this issue Sep 12, 2024
Merged
4 tasks
@felixarntz felixarntz moved this from Not Started/Backlog 📆 to To Do 🔧 in WP Performance 2025 Sep 12, 2024
@westonruter westonruter moved this from To Do 🔧 to In Progress 🚧 in WP Performance 2025 Sep 12, 2024
@westonruter westonruter self-assigned this Sep 12, 2024
@westonruter westonruter mentioned this issue Sep 12, 2024
Merged
@westonruter westonruter moved this from In Progress 🚧 to Code Review 👀 in WP Performance 2025 Sep 12, 2024
@westonruter
Copy link
Member

PR with fix: #1533

@github-project-automation github-project-automation bot moved this from Code Review 👀 to Done 😃 in WP Performance 2025 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken
Projects
WP Performance 2025
Status: Done 😃
Milestone
webp-uploads 2.2.0
2 participants
@westonruter @felixarntz