Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speculative Loading readme needs improvement #1459

Closed
westonruter opened this issue Aug 12, 2024 · 6 comments · Fixed by #1638
Closed

Speculative Loading readme needs improvement #1459

westonruter opened this issue Aug 12, 2024 · 6 comments · Fixed by #1638
Assignees
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules) [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@westonruter
Copy link
Member

westonruter commented Aug 12, 2024

Feature Description

See feedback from @felixarntz in #1155 (review)

A Google Doc has been shared for collaboration.

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules) labels Aug 12, 2024
@westonruter westonruter added this to the speculation-rules n.e.x.t milestone Aug 12, 2024
@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2025 Aug 12, 2024
@westonruter westonruter moved this from Not Started/Backlog 📆 to In Progress 🚧 in WP Performance 2025 Aug 12, 2024
@felixarntz
Copy link
Member

I added some references and one concrete wording suggestion to the readme in the doc. Let me know what you think!

@felixarntz felixarntz removed their assignment Aug 12, 2024
@westonruter
Copy link
Member Author

Looks like this won't land in time for Monday's release. Since it's the only substantive user-facing change in plugin's milestone, I'm not planning to do a release for this plugin on Monday. I've removed the milestone's due date from being set to Monday.

@eclarke1 eclarke1 assigned felixarntz and unassigned tunetheweb Nov 4, 2024
@felixarntz
Copy link
Member

This got stalled a bit, apologies. I just took a fresh look at the readme doc and added a few more suggestions.

Let's keep using suggestions (without approving them) so that it's easy to spot the changes and paste them back into the readme.txt file later.

I'd appreciate another review from you @tunetheweb @westonruter.

@westonruter
Copy link
Member Author

@felixarntz I added a few more suggestions/comments! But it's looking close.

@felixarntz
Copy link
Member

@westonruter Just reviewed, and made 2 more small suggestions, but at this point, all suggestions that are on there look good to me.

I think there's enough benefit to these updates to move forward and already update the readme, despite an outstanding comment on https://docs.google.com/document/d/1cQQG7WUCJolqwdWHSIuj1D05AFHLCdaPUIA1uyNJk0g/edit?resourcekey=0-7L9olr8TFD2oPzw701Warg&disco=AAABNWfek_c.

I'll open a PR with the changes later today or tomorrow, we could still follow up with any further updates if needed.

@westonruter
Copy link
Member Author

Great. Once you've opened that PR and then it and #1636 are merged, we can commit those readme updates to SVN.

@github-project-automation github-project-automation bot moved this from Code Review 👀 to Done 😃 in WP Performance 2025 Nov 11, 2024
@felixarntz felixarntz added the no milestone PRs that do not have a defined milestone for release label Nov 15, 2024
@felixarntz felixarntz removed this from the speculation-rules n.e.x.t milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Status: Done 😃
Development

Successfully merging a pull request may close this issue.

3 participants