-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speculative Loading readme needs improvement #1459
Comments
I added some references and one concrete wording suggestion to the readme in the doc. Let me know what you think! |
Looks like this won't land in time for Monday's release. Since it's the only substantive user-facing change in plugin's milestone, I'm not planning to do a release for this plugin on Monday. I've removed the milestone's due date from being set to Monday. |
This got stalled a bit, apologies. I just took a fresh look at the readme doc and added a few more suggestions. Let's keep using suggestions (without approving them) so that it's easy to spot the changes and paste them back into the I'd appreciate another review from you @tunetheweb @westonruter. |
@felixarntz I added a few more suggestions/comments! But it's looking close. |
@westonruter Just reviewed, and made 2 more small suggestions, but at this point, all suggestions that are on there look good to me. I think there's enough benefit to these updates to move forward and already update the readme, despite an outstanding comment on https://docs.google.com/document/d/1cQQG7WUCJolqwdWHSIuj1D05AFHLCdaPUIA1uyNJk0g/edit?resourcekey=0-7L9olr8TFD2oPzw701Warg&disco=AAABNWfek_c. I'll open a PR with the changes later today or tomorrow, we could still follow up with any further updates if needed. |
Great. Once you've opened that PR and then it and #1636 are merged, we can commit those readme updates to SVN. |
Feature Description
See feedback from @felixarntz in #1155 (review)
A Google Doc has been shared for collaboration.
The text was updated successfully, but these errors were encountered: