Optimization Detective should be enabled by default for admins #1425
Labels
[Plugin] Optimization Detective
Issues for the Optimization Detective plugin
[Type] Enhancement
A suggestion for improvement of an existing feature
Milestone
Optimization Detective currently only applies its optimizations by default when the user is not an admin. The logic is here:
performance/plugins/optimization-detective/optimization.php
Lines 82 to 104 in 08eba80
This can be easily overridden via the following, which is super helpful during development (but see #1423):
However, it can be confusing to be required to do this. The README includes this bit:
Additional elements include Customizer scripts, edit post links, and so on.
If we included admins, then we'd need to modify
od_get_normalized_query_vars()
as follows to vary the URL Metrics by whether the user is an admin (due to the additional elements present for admins):This means that for every URL, there would potentially be separate
od_url_metrics
posts for:Maybe this still isn't worthwhile to do and the existing logic is correct. But I wanted to open an issue to discuss further.
The text was updated successfully, but these errors were encountered: