Include Optimization Detective plugin version in ETag data

westonruter · westonruter · commit c47a61305513 · 2025-01-22T11:34:43.000-08:00
diff --git a/plugins/optimization-detective/storage/data.php b/plugins/optimization-detective/storage/data.php
@@ -200,6 +200,7 @@ function od_get_current_url_metrics_etag( OD_Tag_Visitor_Registry $tag_visitor_r
 	}
 
 	$data = array(
+		'od_version'       => OPTIMIZATION_DETECTIVE_VERSION,
 		'tag_visitors'     => array_keys( iterator_to_array( $tag_visitor_registry ) ),
 		'queried_object'   => $queried_object_data,
 		'queried_posts'    => array_filter(
diff --git a/plugins/optimization-detective/tests/storage/test-data.php b/plugins/optimization-detective/tests/storage/test-data.php
@@ -533,7 +533,7 @@ static function ( array $data ) use ( &$captured_etag_data ) {
 		$etag = $get_etag();
 		$this->assertMatchesRegularExpression( '/^[a-z0-9]{32}\z/', $etag );
 		$this->assertIsArray( $captured_etag_data );
-		$expected_keys = array( 'tag_visitors', 'queried_object', 'queried_posts', 'active_theme', 'current_template' );
+		$expected_keys = array( 'od_version', 'tag_visitors', 'queried_object', 'queried_posts', 'active_theme', 'current_template' );
 		foreach ( $expected_keys as $expected_key ) {
 			$this->assertArrayHasKey( $expected_key, $captured_etag_data );
 		}

Original file line number	Diff line number	Diff line change
`@@ -200,6 +200,7 @@ function od_get_current_url_metrics_etag( OD_Tag_Visitor_Registry $tag_visitor_r`
`200`	`200`	`}`
`201`	`201`
`202`	`202`	`$data = array(`
	`203`	`+ 'od_version' => OPTIMIZATION_DETECTIVE_VERSION,`
`203`	`204`	`'tag_visitors' => array_keys( iterator_to_array( $tag_visitor_registry ) ),`
`204`	`205`	`'queried_object' => $queried_object_data,`
`205`	`206`	`'queried_posts' => array_filter(`
Original file line number	Diff line number	Diff line change
`@@ -533,7 +533,7 @@ static function ( array $data ) use ( &$captured_etag_data ) {`
`533`	`533`	`$etag = $get_etag();`
`534`	`534`	`$this->assertMatchesRegularExpression( '/^[a-z0-9]{32}\z/', $etag );`
`535`	`535`	`$this->assertIsArray( $captured_etag_data );`
`536`		`- $expected_keys = array( 'tag_visitors', 'queried_object', 'queried_posts', 'active_theme', 'current_template' );`
	`536`	`+ $expected_keys = array( 'od_version', 'tag_visitors', 'queried_object', 'queried_posts', 'active_theme', 'current_template' );`
`537`	`537`	`foreach ( $expected_keys as $expected_key ) {`
`538`	`538`	`$this->assertArrayHasKey( $expected_key, $captured_etag_data );`
`539`	`539`	`}`