Remove rememberPossiblyImpureFunctionValues:false from PHPStan config

westonruter · westonruter · commit b86637e72644 · 2024-05-07T09:54:29.000-07:00
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -3,7 +3,6 @@ includes:
 parameters:
 	level: 6
 	treatPhpDocTypesAsCertain: false
-	rememberPossiblyImpureFunctionValues: false
 	checkGenericClassInNonGenericObjectType: false
 	paths:
 		- load.php
diff --git a/tests/plugins/webp-uploads/image-edit-tests.php b/tests/plugins/webp-uploads/image-edit-tests.php
@@ -397,7 +397,11 @@ public function it_should_use_the_next_available_hash_for_the_full_size_image_on
 		remove_filter( 'wp_update_attachment_metadata', 'webp_uploads_update_attachment_metadata' );
 
 		$editor->rotate_right()->save();
-		$this->assertSizeNameIsHashed( 'full', webp_uploads_get_next_full_size_key_from_backup( $attachment_id ) );
+
+		$full_size_key = webp_uploads_get_next_full_size_key_from_backup( $attachment_id );
+		// @phpstan-ignore-next-line -- Work around PHPStan remembering the return value above being null but now being a string. This is instead of adding rememberPossiblyImpureFunctionValues:false to the config.
+		$this->assertIsString( $full_size_key );
+		$this->assertSizeNameIsHashed( 'full', $full_size_key );
 	}
 
 	/**
