Use static var to prevent recomputing version needlessly

westonruter · dmsnell · westonruter · commit b3fbf5c229f1 · 2024-04-10T10:11:02.000-07:00
Co-authored-by: dmsnell &lt;dmsnell@git.wordpress.org&gt;
diff --git a/plugins/optimization-detective/class-od-html-tag-processor.php b/plugins/optimization-detective/class-od-html-tag-processor.php
@@ -194,12 +194,17 @@ public function append_html( string $bookmark, string $html ): bool {
 					return false;
 				}
 
+				// WordPress 6.5 changed the $end arg in the WP_HTML_Text_Replacement constructor to $length.
+				static $is_old_text_replacement_signature = null;
+				if ( null === $is_old_text_replacement_signature ) {
+					$is_old_text_replacement_signature = version_compare( get_bloginfo( 'version' ), '6.5', '<' );
+				}
+
 				$start = $this->bookmarks[ $bookmark ]->start;
 
 				$this->lexical_updates[] = new WP_HTML_Text_Replacement(
 					$start,
-					// In WordPress 6.5, the signature was changed from $end to $length.
-					version_compare( get_bloginfo( 'version' ), '6.5', '<' ) ? $start : 0,
+					$is_old_text_replacement_signature ? $start : 0,
 					$html
 				);
 				return true;
